help on sheet metal script
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
First thank you for the sheet metal work bench. If it is working properly, definitely you can add.
Re: help on sheet metal script
@jaisejames, your script works great, but it is not backward compatible. If you try to load old files with sheetmetal, and try to modify old bends, it will throw an error. I have fixed that so it will work, and commited the changes.
See line 193, if you want to know what I added.
Thanks!
shai
See line 193, if you want to know what I added.
Thanks!
shai
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
Another option added "Simple Fold". please check & tell me, it will be useful or not.
Selection face is same as bend.
Selection face is same as bend.
- Attachments
-
- SimpleFold.py
- (8.6 KiB) Downloaded 64 times
Re: help on sheet metal script
Can you explain what it does and how you integrated it?
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
I added simple edit option to bend.
Double click on sheet metal to open. Useful to rescue for some cases model is broken due to topological name changing
Double click on sheet metal to open. Useful to rescue for some cases model is broken due to topological name changing
- Attachments
-
- sheetmetal edit.png (8.26 KiB) Viewed 1652 times
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
I modified sheetmetalCmd.py[attached]
* Rectified miter-angle code work with unfold
* Added Round Relief
* Added extend wall to add corner relief [manual process]
* double click to edit face selected [ work if base created part workbench, not working in PartDesign Exception : getEditDialog() not implemented ]
* Rectified miter-angle code work with unfold
* Added Round Relief
* Added extend wall to add corner relief [manual process]
* double click to edit face selected [ work if base created part workbench, not working in PartDesign Exception : getEditDialog() not implemented ]
- Attachments
-
- SheetMetalCmd.py
- (19.76 KiB) Downloaded 64 times
Re: help on sheet metal script
Good stuff, thanks. Do I have to exchange the attached file manually or is it sufficient to update via Addon Manager?
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
Backup your exsisting sheetmetalCmd.py, then copy & replace.
Re: help on sheet metal script
Hi Jaisejams,
I like your changes!
I want to add it officially to the WB. It looks like the round relief option works good and also backward compatible, so this is very good.
But I have some issues with the edit window.
1. If there are more then one face bended, I can see only one in the list. Pressing the add, actualy replace the current face, not adding. Is it intended?
2. Pressing Add without selecting anything generates an error.
3. a bit related to 1: selecting more then one face and pressing add, again shows only one face, even though actually when pressing OK, both faces will be bended.
4. If you find a way to make it work on "Part Design" as well, this will be great. If not, maybe just show a message that it works only on "Part".
Great work!
shai
I like your changes!
I want to add it officially to the WB. It looks like the round relief option works good and also backward compatible, so this is very good.
But I have some issues with the edit window.
1. If there are more then one face bended, I can see only one in the list. Pressing the add, actualy replace the current face, not adding. Is it intended?
2. Pressing Add without selecting anything generates an error.
3. a bit related to 1: selecting more then one face and pressing add, again shows only one face, even though actually when pressing OK, both faces will be bended.
4. If you find a way to make it work on "Part Design" as well, this will be great. If not, maybe just show a message that it works only on "Part".
Great work!
shai
-
- Posts: 384
- Joined: Sat Sep 24, 2016 6:51 am
Re: help on sheet metal script
Edit is implemented to rescue model as no of face changes during adding gap or extend, selected bend face will shift to another face than required. Currently We do not any Gui or data tab editing like property-link method to change face.
It will do for current selected bend only.
We hope that somebody experienced like yorik or wmayer implement editing for selected face like they implemented for propertylink and liklist.
Example it is possible like our expression editor, on click, it will be in observe mode & clik OK or Disard will exit.
It will do for current selected bend only.
We hope that somebody experienced like yorik or wmayer implement editing for selected face like they implemented for propertylink and liklist.
Example it is possible like our expression editor, on click, it will be in observe mode & clik OK or Disard will exit.