Python Multithreaded with MULTICORE [Solved]

[vocx]

...
About a PR to FreeCAD, it is not clear where to put the file. I am not very familiar with internal FreeCAD code structure. ...

If this is truly independent of any workbench, then you could perhaps place it in src/3rdParty/, just like lazy_loader, which is a small class taken from the TensorFlow project.

[mnesarco]

If this is truly independent of any workbench, then you could perhaps place it in src/3rdParty/, just like lazy_loader, which is a small class taken from the TensorFlow project.

It is independent. The only thing to change is the first code line

Code: Select all

from freecad.marz.extension import App, QtCore

to

Code: Select all

import FreeCAD as App
from PySide import QtCore

If you really think it is ready for general use, I can send the PR, but it could be advisable to wait some comments from people that use it in their own projects, I wrote it to solve a specific problem in MarzWorkbench and it works very well in that context. But I have no feedback from other devs/contexts.

[vocx]

...
But I have no feedback from other devs/contexts.

Well, I haven't used it. I would at least try it if it was already in the source, but otherwise we can wait for etrombly's feedback.

Truth is development in FreeCAD is perhaps wilder than you may expect; we add things without thinking too much about them because it's better to keep dynamic development going on. If it turns out it wasn't a good idea, we can remake or undo the changes, that's pretty much how we've gotten to this point (which is maybe a bit messy, but hey it's dynamic).

[etrombly]

If you really think it is ready for general use, I can send the PR, but it could be advisable to wait some comments from people that use it in their own projects, I wrote it to solve a specific problem in MarzWorkbench and it works very well in that context. But I have no feedback from other devs/contexts.

I'll let you know once I've tested a little more. The only thing I changed so far is adding an isDone() method that just returns self._isTerminated so you don't have to block like in get().

[mnesarco]

I'll let you know once I've tested a little more. The only thing I changed so far is adding an isDone() method that just returns self._isTerminated so you don't have to block like in get().

Thank you for your feedback.

... adding an isDone() method that just returns self._isTerminated so you don't have to block like in get().

Yes that version is pretty simplified and contains only needed things used in MarzWorkbench, I have started a more generic and complete version with support for signals/slots to monitor the threads but it is used in another internal project. I will explore the possibility to publish that version.

[mnesarco]

BTW, there is also a useful Worker implementation in ExtMan and it is 100% standalone also:

https://github.com/mnesarco/FreeCAD_Ext ... /worker.py

Usage

Code: Select all

# Define your task function
def mytask(...):
   ....
   return something

# If you want to be notified async, define a listener
def mylistener( data ):
  result, error, target = data
  ....

# Create a job with your task
job = Worker(mytask, ...)

# get result async [optional]
job.signals.finished.connect( mylistener )

# Start the job in another thread
job.start()

# get result blocking [optional]
result = job.get()