[ Fixed ] [ Bug ] Snap icons near cursor are missing

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
Palmtree
Posts: 104
Joined: Wed Apr 08, 2020 5:06 am

Re: [ Bug ] Snap icons near cursor are missing

Post by Palmtree »

YES CONFIRMED, the shape is missing for all snaps (it is an arrow instead of a + shape).

**************************************
**************************************

Code: Select all

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.21.29997 (Git)
Build type: Release
Branch: master
Hash: b52967d52ac46eff7c59e74d991f3f5b298944ef
Python 3.10.5, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.2
Locale: English/Australia (en_AU)
Installed mods: 
  * Behave-Dark-Colors 0.1.1
  * BIM 2021.12.0
  * dodo
  * Dracula 0.0.2
  * Help 1.0.3
  * Parts_library
  * PieMenu
  * ProDarkThemePreferencePack 1.0.0
  * SketchArch
**************************************
**************************************
Attachments
Image1.jpg
Image1.jpg (328.25 KiB) Viewed 910 times
Syres
Veteran
Posts: 2891
Joined: Thu Aug 09, 2018 11:14 am

Re: [ Bug ] Snap icons near cursor are missing

Post by Syres »

Roy_043 wrote: Fri Aug 05, 2022 8:56 am Version: 0.21.29923 (Git)
I'll get you the root cause commit as it doesn't seem to be mentioned here, it's a long git bisect but I'm down to the last 30 commits!!
Syres
Veteran
Posts: 2891
Joined: Thu Aug 09, 2018 11:14 am

Re: [ Bug ] Snap icons near cursor are missing

Post by Syres »

OK, git commit 3b0b777 has the culprit in it's many changes. I'll try my best to work through them (some are just comment additions) and find the root cause before I pester Werner. Please don't expect any further feedback before midday UK time tomorrow, any quicker and it's a bonus, I'm melting slowly!!
User avatar
Roy_043
Veteran
Posts: 8410
Joined: Thu Dec 27, 2018 12:28 pm

Re: [ Bug ] Snap icons near cursor are missing

Post by Roy_043 »

Thanks for your efforts. Sometimes finding the bug is the hardest part.
Syres
Veteran
Posts: 2891
Joined: Thu Aug 09, 2018 11:14 am

Re: [ Bug ] Snap icons near cursor are missing

Post by Syres »

Well, I have tried so many different combinations of manually reverting each file either one at a time or in batches and I've literally got nowhere.

@wmayer As you can see from the OP there is a regression in that the Draft Snapper cursor doesn't change to a cross and the symbol for the snap such as end point isn't shown.
I'm completely happy that the last good commit is git commit 864c9ec (0.21.29714) and the first bad commit is git commit 3b0b777 (0.21.29715) I can't do a straight forward Git Revert due to some of the 23 files being changed since. Therefore i attempted to do a manual revert on each file in order to determine which affects the Draft Snap cursor to no avail. Are you at least able to point me in the right direction?
wmayer
Founder
Posts: 20203
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [ Bug ] Snap icons near cursor are missing

Post by wmayer »

Syres
Veteran
Posts: 2891
Joined: Thu Aug 09, 2018 11:14 am

Re: [ Bug ] Snap icons near cursor are missing

Post by Syres »

wmayer wrote: Thu Aug 11, 2022 9:51 am git commit 2b5b7cd607
Thank you
User avatar
thomas-neemann
Veteran
Posts: 11729
Joined: Wed Jan 22, 2020 6:03 pm
Location: Osnabrück DE 🇩🇪
Contact:

Re: [ Bug ] Snap icons near cursor are missing

Post by thomas-neemann »

Syres wrote: Thu Aug 11, 2022 10:15 am
wmayer wrote: Thu Aug 11, 2022 9:51 am git commit 2b5b7cd607
Thank you
+1
Gruß Dipl.-Ing. (FH) Thomas Neemann

https://www.youtube.com/@thomasneemann5 ... ry=freecad
User avatar
Roy_043
Veteran
Posts: 8410
Joined: Thu Dec 27, 2018 12:28 pm

Re: [ Bug ] Snap icons near cursor are missing

Post by Roy_043 »

Thanks from me as well. I am currently working on some snap related code and it certainly helps to see those icons when I test things.
Post Reply