[PR] [0.18-0.21_pre] Arch Stair - More Geometry Control? Profile Generator

[paullee]

Thanks!

Happy New Year 2019 to All!


There seems quite some bugs to fix ...

Screenshot from 2019-01-01 06-47-24.png (175.37 KiB) Viewed 1990 times

[paullee]

Seem good start for 2019

Screenshot from 2019-01-01 08-05-55.png (292.22 KiB) Viewed 1985 times

[paullee]

Maybe nobody need a landing like these... just for fun ?

Screenshot from 2019-01-01 08-21-18.png (320.84 KiB) Viewed 1980 times

Screenshot from 2019-01-01 08-31-14.png (265.13 KiB) Viewed 1980 times

[paullee]

A 'side-effect' during 'debugging tests' - found 'sort-of-bug' / 'unreliable' in Part.sortEdges(), that may related to ArchWall Creation 'bugs' I reported occasionally

1. I used Part.sortEdges() in the current job for curvilinear landing (see code below)
2. Notice some edges in Sketch's Shape.Edges in obj.Base OCCASIONALLY become missing after Part.sortEdges()
3. Resulted in missing final edges, then part of the landing
4. Recompute the Sketch, then it is back (similar 'syndrome' as ArchWall Creation 'bug'
5. Not yet tested Draw / Part Wire

Before any other idea, I may just keep using Part.sortEdges(), need recompute() occasionally

Or should also ping @abdullah, @realthunder who seems have discussed something about Part.sortEdges() if my memory is correct ?


Code

Code: Select all

    print (obj.Base.Shape.Edges)

    ## TODO - Found Part.sortEdges() occasionally return less edges then 'input'
    edges = Part.sortEdges(obj.Base.Shape.Edges)[0]	## TODO - same result as edges = obj.Base.Shape.OrderedVertexes ?

    print (edges)

Output in Report - Missing Edges after sortEdges()

Code: Select all

DEBUG - 2019.1.2
obj.Base.Shape.Edges
[<Edge object at 0x7650170>, <Edge object at 0x7021c60>, <Edge object at 0x6be4a60>, <Edge object at 0x43e89e0>, <Edge object at 0x72032d0>]
edges = Part.sortEdges(obj.Base.Shape.Edges)[0]
[<Edge object at 0x7b44ae0>, <Edge object at 0x72032d0>, <Edge object at 0x7b8bd80>, <Edge object at 0x8c74ca0>]

'Output' of Shape / Landing - Missing 1 last Landing

Screenshot from 2019-01-02 14-07-23.png (177.73 KiB) Viewed 1950 times

Now... recompute()
'Output' of Shape / Landing - After Recompute() - All edges / landing normally come back

Screenshot from 2019-01-02 14-07-39.png (209.71 KiB) Viewed 1950 times

[yorik]

Notice some edges in Sketch's Shape.Edges in obj.Base OCCASIONALLY become missing after Part.sortEdges()
should also ping @abdullah, @realthunder who seems have discussed something about Part.sortEdges() if my memory is correct ?

Would you be able to produce a test file with a sketch that presents the problem? Otherwise it's hard to debug...

[paullee]

Yes, see if I can single out what is before and after... or it is other problem in sketch...

[hammax]

… will there also be sometime a "simple" way to design stairs in / around a corner?
Or only the section between the straight stair parts. E.g. a section of a spiral staircase cut with a cube?

L_Stairs.PNG (27.5 KiB) Viewed 1863 times

L_Stairs_2.PNG (24.13 KiB) Viewed 1863 times

[paullee]

… will there also be sometime a "simple" way to design stairs in / around a corner?
Or only the section between the straight stair parts. E.g. a section of a spiral staircase cut with a cube?

Not sure I understand you. For simple right angle turn stairs, something like this?

Just 3 sketches with 3 lines, select them in order, and press ArchStairs button

.... found some bugs in the progress, good for debugging

Screenshot from 2019-01-05 19-58-19.png (118.63 KiB) Viewed 1863 times

Screenshot from 2019-01-05 19-58-55.png (199.76 KiB) Viewed 1863 times

[hammax]

… I was looking for an easy / closed procedure to model something like this kind of staircase.

L_Stairs_3.PNG (29.06 KiB) Viewed 1847 times

[yorik]

But this file doesn't show the problem of the result of sortEdges() missing some edges... That's what would be interesting