[PR] [0.18-0.21_pre] Arch Stair - More Geometry Control? Profile Generator
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: [PR] Arch Stair - More Geometry Control? Bug Report
ArchStairs can be created without base object (e.g Dwire, Sketch etc.)... Railing is also automatically created for this case now.
0.18_pre ArchStairs.py attached below, appreciate anyone can test before PR.
0.17 version can be back ported if anyone interested (a few commits not yet back ported at the moment)
0.18_pre ArchStairs.py attached below, appreciate anyone can test before PR.
0.17 version can be back ported if anyone interested (a few commits not yet back ported at the moment)
- Attachments
-
- ArchStairs.py
- (51.62 KiB) Downloaded 64 times
Re: [PR] Arch Stair - More Geometry Control? Bug Report
For stairs created without railing ... (or for any reason with railing)...
Select the Stairs and Run the commands Railing (re)-Created
- created in previous versions
- railings deleted etc.
- Select the (master) Stairs
- Run...
Code: Select all
import ArchStairs ArchStairs.makeRailing(None)
- Then, Railings are re-Created, and are inserted in Additions
Select the Stairs and Run the commands Railing (re)-Created
- Attachments
-
- ArchStairs.py
- (52.31 KiB) Downloaded 56 times
Re: [PR] Arch Stair - More Geometry Control? Opening at Floor?
Thinking if something similar to Arch Window - Arch Wall could be done for Arch Stairs - 'Arch Slab / Structure / Roof'? -
(recently there are some discussion about Arch Window and opening on Arch Wall...)
E.g. Arch Structure (as slab) could automatically create an slab opening if it host an Arch Stairs?
(or in other way like current Window)
Anybody (Yorik, Vocx...) want to implement?
(recently there are some discussion about Arch Window and opening on Arch Wall...)
E.g. Arch Structure (as slab) could automatically create an slab opening if it host an Arch Stairs?
(or in other way like current Window)
Anybody (Yorik, Vocx...) want to implement?
Re: [PR] Arch Stair - More Geometry Control? Opening at Floor?
That would not be too hard, indeed we can reuse exactly the same system. Basically:
- The Stairs object should have a "Hosts" property
- The Stairs object needs to trigger recompute of its hosts when needed (like in ArchWindow.py line 978)
- The Stairs object should have a getSubVolume(self,obj) method that returns a shape to be subtracted from host objects
- Maybe the Stairs object would also need a "Subtraction height" property, to allow to user to define the max height of the hole, like in windows
- There might be need for small further adjustments (ex. ArchComponent.py, line 537) to extend to other types (I think we could change that line to something like if hasattr(o.Proxy,"getSubVolume") so in the future, any object that has a getSubVolume() method will be considered
- The Stairs object should have a "Hosts" property
- The Stairs object needs to trigger recompute of its hosts when needed (like in ArchWindow.py line 978)
- The Stairs object should have a getSubVolume(self,obj) method that returns a shape to be subtracted from host objects
- Maybe the Stairs object would also need a "Subtraction height" property, to allow to user to define the max height of the hole, like in windows
- There might be need for small further adjustments (ex. ArchComponent.py, line 537) to extend to other types (I think we could change that line to something like if hasattr(o.Proxy,"getSubVolume") so in the future, any object that has a getSubVolume() method will be considered
Re: [PR] Arch Stair - More Geometry Control? Opening at Floor?
I will never help you while you keep doing this: why is the Report view and Python console using a Serif font like Times?! Why?! The report view should use a monospace font, like Consolas, or Liberation Mono. Why do you use Times?! It burns my eyes! Aaah.
Always add the important information to your posts if you need help. Also see Tutorials and Video tutorials.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
Re: [PR] Arch Stair - More Geometry Control? Opening at Floor?
? Anywhere I can set this ? I just download the *.AppImage and fire it up. Where can I 'correct' this ? Thanks for pointing it outvocx wrote: ↑Fri Oct 26, 2018 5:47 pm I will never help you while you keep doing this: why is the Report view and Python console using a Serif font like Times?! Why?! The report view should use a monospace font, like Consolas, or Liberation Mono. Why do you use Times?! It burns my eyes! Aaah.
Screenshot from 2018-10-26 07-21-07.png
Thanks! Seem much easier to understand the system with this summary! I am trying to turn some ArchStairs methods accessible. See if I get lot of courage to attempt afterwards or leave it to the mastersyorik wrote: ↑Fri Oct 26, 2018 3:13 pm That would not be too hard, indeed we can reuse exactly the same system. Basically:
- The Stairs object should have a "Hosts" property
- The Stairs object needs to trigger recompute of its hosts when needed (like in ArchWindow.py line 978)
- The Stairs object should have a getSubVolume(self,obj) method that returns a shape to be subtracted from host objects
- Maybe the Stairs object would also need a "Subtraction height" property, to allow to user to define the max height of the hole, like in windows
- There might be need for small further adjustments (ex. ArchComponent.py, line 537) to extend to other types (I think we could change that line to something like if hasattr(o.Proxy,"getSubVolume") so in the future, any object that has a getSubVolume() method will be considered
Re: [PR] Arch Stair - More Geometry Control? Opening at Floor?
Menu > Edit > Preferences ... > General > Editor > Family: Liberation Monopaullee wrote: ↑Fri Oct 26, 2018 6:29 pm? Anywhere I can set this ? I just download the *.AppImage and fire it up. Where can I 'correct' this ? Thanks for pointing it outvocx wrote: ↑Fri Oct 26, 2018 5:47 pm I will never help you while you keep doing this: why is the Report view and Python console using a Serif font like Times?! Why?! The report view should use a monospace font, like Consolas, or Liberation Mono. Why do you use Times?! It burns my eyes! Aaah.
Screenshot from 2018-10-26 07-21-07.png
Always add the important information to your posts if you need help. Also see Tutorials and Video tutorials.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
Re: [PR] [0.18] Arch Stair - More Geometry Control? Opening at Floor?
Now, the 'multi-segment' landing can take curve
not fully tested.
Railing not yet
not fully tested.
Railing not yet
Last edited by paullee on Tue Feb 12, 2019 4:58 pm, edited 1 time in total.
Re: [PR] Arch Stair - More Geometry Control? Opening at Floor?
Awesome development! Keep it going!!