Discussion: CustomSpacing should be created shapes exceed a length of the host.

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
chakkree
Posts: 327
Joined: Tue Jun 30, 2015 12:58 am
Location: Bangkok Thailand

Discussion: CustomSpacing should be created shapes exceed a length of the host.

Post by chakkree »

In case of the column, the stirrups will be created exceed a height of the column(as the picture below)
I fixed my problem by replacing the code in ArchRebar.py, line 402. By canceling "return" command

Code: Select all

FreeCAD.Console.PrintError("Influence area of rebars is greater than "+ str(reqInfluenceArea) + ".\n")
In my opinion, If the user sets the CustomSpacing property, _Rebar Object should to still create a shape with spacinglist.

RebarStirrup in Column.png
RebarStirrup in Column.png (257.58 KiB) Viewed 706 times
DetailColumn.FCStd
(181.82 KiB) Downloaded 25 times
-------------------------
OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14210 (Git)
Build type: Release
Branch: master
Hash: d2f9ab6a111975fce69c7f29bf3b7ecb8673a2db
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: English/UnitedStates (en_US)
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Discussion: CustomSpacing should be created shapes exceed a length of the host.

Post by yorik »

Could be.. Then the PrintError should become a PrintWarning. What's your opinion Amritpal?
amrit3701 wrote: ping
User avatar
amrit3701
Posts: 343
Joined: Mon Jun 13, 2016 5:37 pm

Re: Discussion: CustomSpacing should be created shapes exceed a length of the host.

Post by amrit3701 »

yorik wrote: Thu Aug 02, 2018 1:08 am Could be.. Then the PrintError should become a PrintWarning. What's your opinion Amritpal?
Hi chakkree and yorik,

I agreed with both of you because if a user tries to create rebars with custom spacing then rebars must be created according to the given input. And at the same time if rebars expand outside the structure element then we can throw warning messages. I will fix this by PR.

Thanks,
Amritpal Singh
Github, Like my work, sponsor me!
Post Reply