Draft Edit improvements

A forum dedicated to the Draft, Arch and BIM workbenches development.
carlopav
Posts: 290
Joined: Mon Dec 31, 2018 1:49 pm

Draft Edit improvements

Postby carlopav » Sun Feb 03, 2019 12:58 pm

Back to stalke you, promise i'll stop tomorrow when I'm back to work. =)
having some fun with the Draft Edit tool and walls:
Senza-titolo-1.gif
Senza-titolo-1.gif (266.85 KiB) Viewed 1436 times
User avatar
yorik
Site Admin
Posts: 11552
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Draft Edit improvements

Postby yorik » Tue Feb 05, 2019 12:32 am

Oh, cool! Did you modify it somehow?
carlopav
Posts: 290
Joined: Mon Dec 31, 2018 1:49 pm

Re: Draft Edit improvements

Postby carlopav » Tue Feb 05, 2019 7:35 am

yorik wrote:
Tue Feb 05, 2019 12:32 am
Oh, cool! Did you modify it somehow?
Yes, i added some more lines to the draft edit tool to make it edit walls base objects. At the moment just if they are single line sketches or every other kind of draft 2d objects, but I'd like to keep working on it...
And btw I'm not sure it's the right approach: I mean, is it preferred to edit the base object or the wall itself with the edit tool? I think the base object, but that's just my opinion.

I think i made also a pull request, but i'm not sure if it worked or not... have you noticed anything on your side?
carlopav
Posts: 290
Joined: Mon Dec 31, 2018 1:49 pm

Re: Draft Edit improvements

Postby carlopav » Tue Feb 05, 2019 7:42 am

I was thinking also to the new 3points arc: i plan to implement an edit option that let you edit every arc object with end/mid/end mode or center/radius/angle/angle mode. That should help because the arc created could be always the same draft object, stored in the same way.
do you agree
carlopav
Posts: 290
Joined: Mon Dec 31, 2018 1:49 pm

Re: Draft Edit improvements

Postby carlopav » Tue Feb 05, 2019 7:43 am

carlopav wrote:
Tue Feb 05, 2019 7:35 am
yorik wrote:
Tue Feb 05, 2019 12:32 am
Oh, cool!
Too kind Yorik
yorik wrote:
Tue Feb 05, 2019 12:32 am
Did you modify it somehow?
Yes, i added some more lines to the draft edit tool to make it edit walls base objects. At the moment just if they are single line sketches or every other kind of draft 2d objects, but I'd like to keep working on it...
And btw I'm not sure it's the right approach: I mean, is it preferred to edit the base object or the wall itself with the edit tool? I think the base object, but that's just my opinion.

I think i made also a pull request, but i'm not sure if it worked or not... have you noticed anything on your side?
paullee
Posts: 1737
Joined: Wed May 04, 2016 3:58 pm

Re: Draft Edit improvements

Postby paullee » Tue Feb 05, 2019 8:09 am

Again! Glad to see there are more people contributing to Arch/BIM WB! :)
User avatar
yorik
Site Admin
Posts: 11552
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Draft Edit improvements

Postby yorik » Wed Feb 06, 2019 12:54 pm

carlopav wrote:
Tue Feb 05, 2019 7:35 am
And btw I'm not sure it's the right approach: I mean, is it preferred to edit the base object or the wall itself with the edit tool? I think the base object, but that's just my opinion.
I think it's the right approach, the same I did with the Stretch tool: From the user point of view, you are just editing the wall. But internally, "programmatically", we are in fact editing the line underneath. But the user doesn't see it.
carlopav wrote:
Tue Feb 05, 2019 7:35 am
I think i made also a pull request, but i'm not sure if it worked or not... have you noticed anything on your side?
I don't see your pull request...
carlopav wrote:
Tue Feb 05, 2019 7:42 am
I was thinking also to the new 3points arc: i plan to implement an edit option that let you edit every arc object with end/mid/end mode or center/radius/angle/angle mode. That should help because the arc created could be always the same draft object, stored in the same way.
do you agree
Yes! I wasn't sure if the new 3-point arc should be stored as the same object as the existing draft arc or not. But indeed if you offer both editing modes, then the question is solved ;)
carlopav
Posts: 290
Joined: Mon Dec 31, 2018 1:49 pm

Re: Draft Edit improvements

Postby carlopav » Wed Feb 06, 2019 4:56 pm

Great, i will work in this direction so.
yorik wrote:
Wed Feb 06, 2019 12:54 pm
I don't see your pull request...
I should have done something wrong... i'll try again tonight!
carlopav
Posts: 290
Joined: Mon Dec 31, 2018 1:49 pm

Re: Draft Edit improvements

Postby carlopav » Wed Feb 06, 2019 8:51 pm

yorik wrote:
Wed Feb 06, 2019 12:54 pm
I don't see your pull request...
I think i did again something wrong merging it without waiting... i had to stop at the pull request... right? ok i'll give a deeper look on how git works, sorry :? :?
carlopav
Posts: 290
Joined: Mon Dec 31, 2018 1:49 pm

Re: Draft Edit improvements

Postby carlopav » Wed Feb 06, 2019 9:14 pm

paullee wrote:
Tue Feb 05, 2019 8:09 am
Again! Glad to see there are more people contributing to Arch/BIM WB! :)
Thanks Paullee, just having some weekend fun for the moment =) but glad to have discovered this great community!