But, why? Of course you can work on that, but I think right now just moving the nodes of various objects (without necessarily showing all options in the task panel) would be useful already.
Draft Edit improvements
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Draft Edit improvements
Always add the important information to your posts if you need help. Also see Tutorials and Video tutorials.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
Re: Draft Edit improvements
I think it would seem buggy if taskpanel doesnt correspond to object that user is editing. And also I needed it this way because i was trying to always enable draft edit (so when user select an object editpoints are displayed automagically).
follow my experiments on BIM modelling for architecture design
Re: Draft Edit improvements
Following your suggestion, PR: https://github.com/FreeCAD/FreeCAD/pull/2699 allow the user to choose the maximum number of objects while editing
follow my experiments on BIM modelling for architecture design
Re: Draft Edit improvements
In following commit i tried to be as clear as possible:
https://github.com/FreeCAD/FreeCAD/pull/2839
I'll try to be as short as i can here in the post, since i tried to document the code.
The following parts of the code should not probably stay in the main Draft Edit.
PREVIEW: from this line on, could be split into every object code or in a general Draft_EditPreview, or maybe better i could add some specific function in draft Trackers to keep edit slim.
ADDITIONAL TOOLS: From this line on, additional tools like addPoint, delPoint, I hope they can become subcommands, activated by a context menu. At the moment, when "add point button" is checked, user click is forwarded to theese functions.
MAIN EDITING FUNCTIONS: These line on should stay inside the tool, since they identify which function to call to getEditPoints and to update the object.
OBJECT EDITING FUNCTIONS: From this line to the end. This is the code i'd like to split more. Since every object is asked for a list of editpoints, and when a point is moved every object is notified and changed, I think this should go to the object class, not inside a graphical editing tool. Expecially for BezCurve and Circle that contains code that could be used by a wide range of functions.
https://github.com/FreeCAD/FreeCAD/pull/2839
I'll try to be as short as i can here in the post, since i tried to document the code.
The following parts of the code should not probably stay in the main Draft Edit.
PREVIEW: from this line on, could be split into every object code or in a general Draft_EditPreview, or maybe better i could add some specific function in draft Trackers to keep edit slim.
ADDITIONAL TOOLS: From this line on, additional tools like addPoint, delPoint, I hope they can become subcommands, activated by a context menu. At the moment, when "add point button" is checked, user click is forwarded to theese functions.
MAIN EDITING FUNCTIONS: These line on should stay inside the tool, since they identify which function to call to getEditPoints and to update the object.
OBJECT EDITING FUNCTIONS: From this line to the end. This is the code i'd like to split more. Since every object is asked for a list of editpoints, and when a point is moved every object is notified and changed, I think this should go to the object class, not inside a graphical editing tool. Expecially for BezCurve and Circle that contains code that could be used by a wide range of functions.
follow my experiments on BIM modelling for architecture design
Re: Draft Edit improvements
I made some progress with context menu in Draft Edit:
As always code was already there, i just had to look better for it
At the moment it is triggered by pressing "e" key while editing or with Alt+left click
EDIT: The branch is here https://github.com/carlopav/FreeCAD/tre ... provements
Now it should be possible to add custom actions to the nodes, so when multi object editing is enabled, the menu exactly shows what you can do with that node.As always code was already there, i just had to look better for it
At the moment it is triggered by pressing "e" key while editing or with Alt+left click
EDIT: The branch is here https://github.com/carlopav/FreeCAD/tre ... provements
follow my experiments on BIM modelling for architecture design
Re: Draft Edit improvements
This is amazing work, @carlopav! Keep it up!
I also blog about 3D rendering, architecture, software and other on thinkMoult.com. RSS / Atom feed available for your convenience.
Re: Draft Edit improvements
Thanks Moult!
BTW may I ask you if I can use the DE shortcut for draft edit and change to SE or SH for subelement highlight?
follow my experiments on BIM modelling for architecture design
Re: Draft Edit improvements
Absolutely go right ahead! Feel free to rewrite / remove / improve any of the stuff that I wrote too! You're doing a great job!
I also blog about 3D rendering, architecture, software and other on thinkMoult.com. RSS / Atom feed available for your convenience.
Re: Draft Edit improvements
Too kind!
EDIT: PR submitted https://github.com/FreeCAD/FreeCAD/pull/2852
EDIT: PR submitted https://github.com/FreeCAD/FreeCAD/pull/2852
follow my experiments on BIM modelling for architecture design
Re: Draft Edit improvements
Added context menu support also for Arc editing.
Updated the PR.
Now i suggest to get rid of the old interface, since it's not updated for multi object editing (and I dont have a good idea on how to update it).
The task panel can just show the close button and a small text that suggest you are in editing mode and you can display options pressing E key or with Alt+Left mouse click
Updated the PR.
Now i suggest to get rid of the old interface, since it's not updated for multi object editing (and I dont have a good idea on how to update it).
The task panel can just show the close button and a small text that suggest you are in editing mode and you can display options pressing E key or with Alt+Left mouse click
- Attachments
-
- 6cJgaviMm2.gif (337.68 KiB) Viewed 1517 times
follow my experiments on BIM modelling for architecture design