[SOLVED] Draft scale v0.18 is broken?

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Moult
Posts: 321
Joined: Sat Jan 05, 2019 11:46 am
Contact:

[SOLVED] Draft scale v0.18 is broken?

Post by Moult »

G'day all, I am using FreeCAD_0.18.15609_Conda_Py3Qt5_glibc2.12-x86_64.AppImage

OS: Gentoo/Linux
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15609 (Git) AppImage
Build type: Release
Branch: master
Hash: a14af0f2bd26f980d71be80a799ee48127bc7619
Python version: 3.6.7
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)

Steps to reproduce:

1. Draw a new draft wire which does not start at the origin. (i.e. the draft wire's placement position is not 0, 0, 0)
2. Select an edge on the wire
3. S,C to start scaling
4. Click a base point
5. Change the scale factor to anything
6. Press OK.

You will notice that the draft wire will jump so that the position is reset to 0, 0, 0.

Can others replicate this? If so, I will attempt to fix it in my PR which is adding the feature to scale subelements.
Last edited by Moult on Sun Mar 03, 2019 6:52 am, edited 1 time in total.
I also blog about 3D rendering, architecture, software and other on thinkMoult.com. RSS / Atom feed available for your convenience.
User avatar
regis
Posts: 751
Joined: Sun Jul 12, 2015 8:17 am
Contact:

Re: Draft scale v0.18 is broken?

Post by regis »

I can concur with you, It seems on the latest version I donwloaded last night, the scale tool seems to be broken and behaves exactly as you have described. except mine doesn't put the new scaled tool at 0,0,0 but puts it way off someone lost in 3D space

FreeCAD_0.18.15972_Conda_Py3Qt5_glibc2.12-x86_64.AppImage

OS: Linux Mint 19.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15972 (Git) AppImage
Build type: Release
Branch: master
Hash: 4e973324ae03c6db9188c08483232fa059c1c9ae
Python version: 3.6.7
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/Canada (en_CA)
Last edited by regis on Sat Mar 02, 2019 9:05 pm, edited 1 time in total.
Marco_T
Posts: 266
Joined: Mon Jan 11, 2016 11:58 pm
Location: Di ca da l'aghe

Re: Draft scale v0.18 is broken?

Post by Marco_T »

Moult wrote: Sat Mar 02, 2019 1:13 am Can others replicate this? If so, I will attempt to fix it in my PR which is adding the feature to scale subelements.
Hi,
here:
OS: Linux Mint 18.3 Sylvia
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15987 (Git)
Build type: Release
Branch: master
Hash: be45d5e7bab63a9c8566803ea1394d88445251dd
Python version: 2.7.12
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Italian/Italy (it_IT)

but also here:
OS: Linux Mint 18.3 Sylvia
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.13541 (Git)
Build type: None
Branch: releases/FreeCAD-0-17
Hash: 9948ee4f1570df9216862a79705afb367b2c6ffb
Python version: 2.7.12
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Italian/Italy (it_IT)

I have this strange behavior.
But only with option "Create a clone" selected.
With options "Modify original" and "Create a copy" selected the result of Scale command is correct.
User avatar
Moult
Posts: 321
Joined: Sat Jan 05, 2019 11:46 am
Contact:

Re: Draft scale v0.18 is broken?

Post by Moult »

Thanks for the confirmations. It is clear something is broken. I will fix.
I also blog about 3D rendering, architecture, software and other on thinkMoult.com. RSS / Atom feed available for your convenience.
User avatar
Moult
Posts: 321
Joined: Sat Jan 05, 2019 11:46 am
Contact:

Re: Draft scale v0.18 is broken?

Post by Moult »

It is "fixed" (except for rectangles, which I think we can deprecate).

Commit: https://github.com/FreeCAD/FreeCAD/pull ... 8823cea776

Marking thread as solved.
I also blog about 3D rendering, architecture, software and other on thinkMoult.com. RSS / Atom feed available for your convenience.
Post Reply