Roof Arch_remove displaced result

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
brjhaverkamp
Posts: 126
Joined: Thu Sep 24, 2015 3:14 pm

Roof Arch_remove displaced result

Post by brjhaverkamp »

Hi all,

Here is my next puzzle with my attic project, and possibly an other bug.
I was cleaning up my model, based on the things I learned about the Arch workbench.
So last evening I tried to replace the boolean subtract of the holes for the dormers in my roof with a Arch-Remove.
However, the result is a off by a distance of about 80 cm. This could be the placement offset that I gave the roof wrt the floorplan it is based upon.

Or am I overlooking something? All suggestions are welcome.

I have added the example file and a screenshot of my puzzle below
Screenshot (26).png
Screenshot (26).png (355.45 KiB) Viewed 2048 times
Kind regards,

Bert
Attachments
Roof subtraction.FCStd
(320.27 KiB) Downloaded 47 times
User avatar
regis
Posts: 735
Joined: Sun Jul 12, 2015 8:17 am
Contact:

Re: Roof Arch_remove displaced result

Post by regis »

hard to guesstimate what's wrong with your stuffs at this point, honestly I can't tell what's wrong with your model after looking at it. My best suggestion is just delete the Roof holes and create a new one.
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Roof Arch_remove displaced result

Post by Roy_043 »

Fixing this is relatively easy: instead of changing the placement of the 'Roof', change the placement of the underlying sketch. The same approach that was used for 'Roof holes'.
I am inclined to call what you are seeing a bug. You could argue that the Z of the 'Roof' logically has an impact on nested objects. But you would then expect the solid of the 'Roof holes' to be in a higher position.
brjhaverkamp
Posts: 126
Joined: Thu Sep 24, 2015 3:14 pm

Re: Roof Arch_remove displaced result

Post by brjhaverkamp »

Thanks for checking and confirming Roy,

I suspect the z-offset of roof is the cause for this mismatch of the holes. If you think about it: the holes are at exactly the place they would have been if the roof didn't have that z-offset. giving the hole structure the same offset is indeed a valid workaround to get the holes in the intended place.

But I solved it locally now by moving to a boolean subtract because arch_remove became too problematic for now:

The reason is that even though there There is even a second "bug" with the arch_remove method: I use the resulting roof-with-holes to rcut the edges of the walls underneath the roof. But that Arch_remove does not take the holes in the roof into account. So it even cuts the walls where the dormers are placed. Apparently nesting Arch_removes is not working very well.

I posed the question on the goal of Arch_remove in general in the other thread. When that one settles into a conclusion I plan to create a bugreport for both of these issues.

Bert
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: Roof Arch_remove displaced result

Post by paullee »

brjhaverkamp
Posts: 126
Joined: Thu Sep 24, 2015 3:14 pm

Re: Roof Arch_remove displaced result

Post by brjhaverkamp »

I created a bug for this on Mantis to keep track.

https://www.freecadweb.org/tracker/view.php?id=3909

Regards,

Bert
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: Roof Arch_remove displaced result

Post by paullee »

User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Roof Arch_remove displaced result

Post by Roy_043 »

paullee wrote: Mon Jan 18, 2021 11:04 pm Update in Mantis : Similar / related Forum Discussion-
Are you sure these issues are related?
If I open the model in the OP in the version listed below, change the IdRel of the Id=0 roof segment to -1 and then recompute, there are no displaced results. IMO this bug has been fixed in the latest version of ArchRoof:

https://forum.freecadweb.org/viewtopic.php?f=23&t=52035
https://github.com/FreeCAD/FreeCAD/pull/4054

Code: Select all

OS: Windows 8.1 (6.3)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.23546 (Git)
Build type: Release
Branch: master
Hash: 6b017f9a16b15b0e628c8d874c4058442dee5548
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Dutch/Netherlands (nl_NL)
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Roof Arch_remove displaced result

Post by Roy_043 »

Roy_043 wrote: Tue Jan 19, 2021 10:08 pm change the IdRel of the Id=0 roof segment to -1
This should not be required. I'll do a PR to fix this compatibility issue.
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: Roof Arch_remove displaced result

Post by paullee »

Roy_043 wrote: Tue Jan 19, 2021 10:08 pm Are you sure these issues are related?
If I open the model in the OP in the version listed below, change the IdRel of the Id=0 roof segment to -1 and then recompute, there are no displaced results. IMO this bug has been fixed in the latest version of ArchRoof:
Indeed not sure, just an user report that in another discussion, and the symptom is in fact similar, not may not be exactly the same, probably related.

I see you fix processSubShapes(), will see if it fix the other problems.
Post Reply