[PR] Merged - ArchWall to Support Circle (w/o face)

A forum dedicated to the Draft, Arch and BIM workbenches development.
paullee
Posts: 2761
Joined: Wed May 04, 2016 3:58 pm

[PR] Merged - ArchWall to Support Circle (w/o face)

Postby paullee » Tue Jun 18, 2019 5:54 pm

issue #0003859
Hi, there was a ticket about ArcWall to support Parabola, Hyperbola, BSplineCurve, Ellipse, and BezierCurve etc.

ArchWall support Circle with Face - so it create kind of solid circular column type of object. But it does not support Circle w/o Face - so it does not create a Wall in circular form.

Testing to tweak DraftGeomUtils.offsetWire() so that the latter is supported... No idea how to support other geometries, anybody?


Then - ArchWall on Circular Face as Solid Circular Column object
Screenshot from 2019-06-19 01-42-29.png
Screenshot from 2019-06-19 01-42-29.png (162.38 KiB) Viewed 449 times
.
Now - ArchWall on Circular Wire as Circular Wall
Screenshot from 2019-06-19 01-30-29.png
Screenshot from 2019-06-19 01-30-29.png (258.29 KiB) Viewed 449 times
Attachments
Test _ Arch Wall_ on Circle_ 1.fcstd
(7.65 KiB) Downloaded 9 times
Last edited by paullee on Thu Jun 27, 2019 5:11 pm, edited 1 time in total.
carlopav
Posts: 1570
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: [PR] - ArchWall to Support Circle (w/o face)

Postby carlopav » Tue Jun 18, 2019 7:22 pm

WOW!
follow my experiments on BIM modelling for architecture design
paullee
Posts: 2761
Joined: Wed May 04, 2016 3:58 pm

Re: [PR] - ArchWall to Support Circle (w/o face)

Postby paullee » Wed Jun 19, 2019 11:22 pm

PR #2274

(Haven't figured out how to use the commit tag)

https://github.com/FreeCAD/FreeCAD/pull/2274

Hope it works
User avatar
Kunda1
Posts: 8738
Joined: Thu Jan 05, 2017 9:03 pm

Re: [PR] - ArchWall to Support Circle (w/o face)

Postby Kunda1 » Wed Jun 19, 2019 11:54 pm

paullee wrote:
Wed Jun 19, 2019 11:22 pm
PR #2274

(Haven't figured out how to use the commit tag)

https://github.com/FreeCAD/FreeCAD/pull/2274

Hope it works
Commit tag works with the git commit hash associated with the commit. It's in the Github commit URL
Image

There is no commit until a commit is made :)
So you can't use it on Pull Request number or URL, as I assume you were trying :D ;)
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
paullee
Posts: 2761
Joined: Wed May 04, 2016 3:58 pm

Re: [PR] - ArchWall to Support Circle (w/o face)

Postby paullee » Thu Jun 20, 2019 7:05 pm

Thanks :)
paullee
Posts: 2761
Joined: Wed May 04, 2016 3:58 pm

Re: [PR] Merged - ArchWall to Support Circle (w/o face)

Postby paullee » Thu Jun 27, 2019 5:11 pm

Thanks @Kunda1, now I seem understand the way 'Commit' tag is used...

git commit fb18e76d16f8d1a1abd9b1c4d2d1373743a9995a
User avatar
Kunda1
Posts: 8738
Joined: Thu Jan 05, 2017 9:03 pm

Re: [PR] Merged - ArchWall to Support Circle (w/o face)

Postby Kunda1 » Fri Jun 28, 2019 12:08 pm

Congrats :)
BTW, you can shorten the commit hash down to like 10 chars and it will still work ;)
git commit fb18e76d16
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features