[PR] Merged - ArchWall to Support Circle (w/o face)

[paullee]

issue #0003859
Hi, there was a ticket about ArcWall to support Parabola, Hyperbola, BSplineCurve, Ellipse, and BezierCurve etc.

ArchWall support Circle with Face - so it create kind of solid circular column type of object. But it does not support Circle w/o Face - so it does not create a Wall in circular form.

Testing to tweak DraftGeomUtils.offsetWire() so that the latter is supported... No idea how to support other geometries, anybody?


Then - ArchWall on Circular Face as Solid Circular Column object

Screenshot from 2019-06-19 01-42-29.png (162.38 KiB) Viewed 1197 times

.
Now - ArchWall on Circular Wire as Circular Wall

Screenshot from 2019-06-19 01-30-29.png (258.29 KiB) Viewed 1197 times

[carlopav]

WOW!

[paullee]

PR #2274

(Haven't figured out how to use the commit tag)

https://github.com/FreeCAD/FreeCAD/pull/2274

Hope it works

[Kunda1]

PR #2274

(Haven't figured out how to use the commit tag)

https://github.com/FreeCAD/FreeCAD/pull/2274

Hope it works

Commit tag works with the git commit hash associated with the commit. It's in the Github commit URL


There is no commit until a commit is made
So you can't use it on Pull Request number or URL, as I assume you were trying

[paullee]

Thanks

[paullee]

Thanks @Kunda1, now I seem understand the way 'Commit' tag is used...

git commit fb18e76d16f8d1a1abd9b1c4d2d1373743a9995a

[Kunda1]

git commit fb18e76d16f8d1a1abd9b1c4d2d1373743a9995a

Congrats
BTW, you can shorten the commit hash down to like 10 chars and it will still work
git commit fb18e76d16