[ PR - Arch Wall - BUG ] Sketch Base RemoveSplitter Problem - EDITED

[paullee]

[EDIT] 2019.10.13 - maybe it had been 0.18 bug (see below post at https://forum.freecadweb.org/viewtopic. ... 13#p340613)
Title edited.


Dimitar reported Arch Wall do not properly build if base on Sketch in

https://forum.freecadweb.org/viewtopic. ... 50#p326160
https://forum.freecadweb.org/viewtopic. ... 50#p326189
https://forum.freecadweb.org/viewtopic. ... 50#p326197


I further test the same file works properly to build wall on 0.18, but no longer....

"In addition to my test that 0.18 works without problem,
and FreeCAD_0.19-16790-Linux-Conda_Py3Qt5_glibc2.12-x86_64.AppImage had been not working ...

I had
FreeCAD_0.19.16291_Conda_Py3Qt5_glibc2.12-x86_64.AppImage
and it is not working then.."

Screenshot from 2019-08-13 23-53-11.png (121.64 KiB) Viewed 2219 times

[EDIT]

tested below AppImage on Fedora 30

FreeCAD_0.19-16790-Linux-Conda_Py3Qt5_glibc2.12-x86_64.AppImage
FreeCAD_0.19-17512-Linux-Conda_Py3Qt5_glibc2.12-x86_64.AppImage

[paullee]

Found only 'Center' Align is problematic

No problem if it is Left or Right Align ...

Screenshot from 2019-08-13 23-53-11.png (121.64 KiB) Viewed 2210 times

Screenshot from 2019-08-14 01-02-39.png (183.38 KiB) Viewed 2210 times

Screenshot from 2019-08-14 01-02-52.png (178.49 KiB) Viewed 2210 times

[Roy_043]

Interestingly removing the shortest line from the sketch fixes the problem. The same goes for reversing the direction of this line.

Code: Select all

OS: Windows 8.1 (6.3)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.17505 (Git)
Build type: Release
Branch: master
Hash: 755536e9df94d2d39da1468420f1fd333c35da7a
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Dutch/Netherlands (nl_NL)

[paullee]

Pretty weird, no idea what has changed from 0.18.3 to 0.19_pre resulting this ...

... missing edges this time ... no problem in 0.18.3


0.19_pre
FreeCAD_0.19-17512-Linux-Conda_Py3Qt5_glibc2.12-x86_64.AppImage on Fedora 30

Screenshot from 2019-08-20 07-06-43.png (179.96 KiB) Viewed 2105 times

0.18.3

Screenshot from 2019-08-20 07-05-03.png (176.16 KiB) Viewed 2105 times

Screenshot from 2019-08-20 07-05-08.png (209.27 KiB) Viewed 2105 times

[paullee]

Similarly... when align is Center, there is a bug...

When align is left or right, no problem

Screenshot from 2019-08-20 07-12-57.png (161.67 KiB) Viewed 2105 times

Screenshot from 2019-08-20 07-13-12.png (167.01 KiB) Viewed 2105 times

[yorik]

Probably our wire offsetting code in DraftGeomUtils fails. Maybe we could make it more verbose...

[paullee]

Probably our wire offsetting code in DraftGeomUtils fails. Maybe we could make it more verbose...

Thanks looking into this.

But it works on 0.18.3, no longer in 0.19_pre whatever the earliest AppImage I have.

Tried to look at the difference between the 2 version of DraftGeomUtils, but do not notice anything special to my knowledge ...

[paullee]

This time, it is Left Align which return problematic wall solid ?

Curious why 0.18.3 works... no such problem though sketch is complex ...

Screenshot from 2019-08-21 00-55-20.png (209.46 KiB) Viewed 2054 times

Screenshot from 2019-08-21 00-55-14.png (213.14 KiB) Viewed 2054 times

Screenshot from 2019-08-21 00-55-07.png (211.47 KiB) Viewed 2054 times

[paullee]

Probably our wire offsetting code in DraftGeomUtils fails. Maybe we could make it more verbose...

Suspect there maybe something wrong about :-

1. DraftGeomUtils.removeSplitter()
2. removing the ArchWall.getExtrusionData()... removeSplitter ... code make it works again

   Code: Select all

                                           # baseface = baseface.removeSplitter()
                                           #s = DraftGeomUtils.removeSplitter(baseface)
                                           #if s:
                                           #    baseface = s
   

Question is - there is no change in these DraftGeomUtils.removeSplitter() code, why it fails in 0.19_pre, OCC changes?

Screenshot from 2019-08-24 17-04-02.png (217.15 KiB) Viewed 1995 times

[paullee]

Seem i was wrong, repeating test on 0.18, it was not working

(Maybe kind of random?)

( FreeCAD_0.18-16131-Linux-Conda_Py3Qt5_glibc2.12-x86_64.AppImage
on
Fedora 30 )

Screenshot from 2019-10-13 09-03-31.png (148.31 KiB) Viewed 1691 times

Screenshot from 2019-10-13 09-03-34.png (136.9 KiB) Viewed 1691 times