that makes it 3 who don't agree (with the new splitting) and 2 who like it.
So, what do other workbenches think of the new Draft code splitting ?
I'd be curious to know...
You are pushing your own narrative on what others have said. Neither Yorik nor triplus said they don't agree. They said, not too much not too little. Don't extrapolate your feelings because of it.
Well, at the moment, we have this huge DraftGui.py file, so until we can deal with it, and split it apart, we can't organize the taskpanel code inside the Gui Commands. But other than that, yes, we could integrate it. Given that this is runtime code, we can change it without significant problems.
I probably missed one or two steps ... Can you give a more detailed explanation of what do you propose and which would be the pros (or point to the conversation you are referring)?
Lets do the cons first. Currently one opens FreeCAD Wiki or downloads/clones FreeCAD source code and looks inside the Mod folder for clues and starts coding. "Oh no", you shouldn't' be doing that! Instead what you should do is to download/clone workbench starter kit and start from there. In addition people have started to nitpick in Pythonic department:
Code: Select all
import FreeCAD as App import Draft _doc = App.newDocument() p1 = App.Vector(0, 0, 0) p2 = App.Vector(1000, 500, 0) p3 = App.Vector(-250, -500, 0) p4 = App.Vector(500, 1000, 0) Line1 = Draft.makeLine(p1, p2) Line2 = Draft.makeLine(p3, p4) _doc.recompute()
Code: Select all
import freecad as app from freecad.draft import line _doc = app.new_document() P1 = app.vector(0, 0, 0) P2 = app.vector(1000, 500, 0) P3 = app.vector(-250, -500, 0) P4 = app.vector(500, 1000, 0) line_1 = line.make_line(P1, P2) line_2 = line.make_line(P3, P4) _doc.recompute()