[feature request] Section Plane - Cut View Context menu

[carlopav]

Hello! I'm using the arch section plane with great proficiency also while modelling with PartDesign. What I found great is the ability to cut the view to show the inside of the model while I'm modelling.
I think it would speed up things a lot to be able to activate and deactivate CutView property with a right click on the section plane entity on the treeview.
I think this is the right topic https://forum.freecadweb.org/viewtopic.php?t=10255 but i couldn't manage to understand how to correctly place inside the code.
I tried to add this code to the viewprovider section plane:

Code: Select all

    def setupContextMenu(self,vobj,menu):
        from PySide import QtCore,QtGui
        action1 = QtGui.QAction(QtGui.QIcon(":/icons/Draft_Edit.svg"),"Swich on/off Cutview",menu)
        QtCore.QObject.connect(action1,QtCore.SIGNAL("triggered()"),self.contextCutview(vobj))
        menu.addAction(action1)
    
    def contextCutview(self,vobj):
        if vobj.CutView:
            vobj.CutView = False
        else: vobj.CutView = True

but the result is that cutview is activated directly with right click rather than with left click on the menu option (this is super cool, but not the right behaviour i guess).
What am I doing wrong?

[vocx]

...
What am I doing wrong?

Your code doesn't look like the code from Werner in the cited thread, contextmenu for a viewprovider.

It seems like this should be enough.

Code: Select all

class ArchSectionPlaneViewProvider:
    def __init__(self, vobj):
    ...
    def setupContextMenu(self, vobj, menu):
        action = menu.addAction("Switch on/off cutview")
        action.triggered.connect(lambda f=self.contextCutview, arg=vobj:f(arg))

    def contextCutview(self, vobj):
        if vobj.CutView:
            vobj.CutView = False
        else:
            vobj.CutView = True

[carlopav]

Super thanks,
it works. What about if i PR this feature?
I find it really helpful.

[vocx]

...
What am I doing wrong?

By the way, I just realized that your previous attempt was just imitating the code in Draft.py. I didn't notice before. I guess it should work either way.

_ViewProviderWire, https://github.com/FreeCAD/FreeCAD/blob ... t.py#L5118

Code: Select all

    def setupContextMenu(self,vobj,menu):
        from PySide import QtCore,QtGui
        action1 = QtGui.QAction(QtGui.QIcon(":/icons/Draft_Edit.svg"),"Flatten this wire",menu)
        QtCore.QObject.connect(action1,QtCore.SIGNAL("triggered()"),self.flatten)
        menu.addAction(action1)

ViewProviderWorkingPlaneProxy, https://github.com/FreeCAD/FreeCAD/blob ... t.py#L6561

Code: Select all

    def setupContextMenu(self,vobj,menu):
        from PySide import QtCore,QtGui
        action1 = QtGui.QAction(QtGui.QIcon(":/icons/Draft_SelectPlane.svg"),"Write camera position",menu)
        QtCore.QObject.connect(action1,QtCore.SIGNAL("triggered()"),self.writeCamera)
        menu.addAction(action1)
        action2 = QtGui.QAction(QtGui.QIcon(":/icons/Draft_SelectPlane.svg"),"Write objects state",menu)
        QtCore.QObject.connect(action2,QtCore.SIGNAL("triggered()"),self.writeState)
        menu.addAction(action2)

[furti]

@carlopav the problem was that you called self.contextCutView(vobj) directly in setupContextMenu.
Instead one has to pass the function to the connect call like @vocx showed in his samples.

This means "self.contextCutview" without the brackets.

[carlopav]

Thanks, probably I copy pasted something wrong from draft wire command. Now it seem to work.

[carlopav]

I submitted a PR so also yorik can have a look at it:
https://github.com/FreeCAD/FreeCAD/pull/2618

[ABeton]

I am trying to figure out what you did here, but I only understand some bits So does this command allow you to turn on and off the cut view from the context menu when you right click the section plane in the tree view?

[carlopav]

Precisely what you wrote. Every viewprovider object have the possibility to add its own commands in the context menu with this lines.
This doesn't work on the 3d view, just on the treeview.

[ABeton]

Precisely what you wrote. Every viewprovider object have the possibility to add its own commands in the context menu with this lines.
This doesn't work on the 3d view, just on the treeview.

Ok I understand better now. So to do it in the 3D view i will have to use some different code, something like what vocx posted in the other thread.

https://forum.freecadweb.org/viewtopic. ... 1&start=90