New Feature: Notch Connector

A forum dedicated to the Draft, Arch and BIM workbenches development.
User avatar
christi
Posts: 74
Joined: Wed Oct 24, 2018 7:03 am
Location: Karlsruhe, Germany
Contact:

New Feature: Notch Connector

Postby christi » Sat Feb 29, 2020 3:56 pm

I have written a new tool "Notch Connector". It cuts notches into the overlapping part of two bars

Image

Currently it is in the Curved Shapes workbench, but it does not really fit in there. Maybe the Arch workbench is a better place.

Does anybody want to copy this to another workbench. ? I will then delete it from Curved Shapes.
Last edited by Kunda1 on Sat Feb 29, 2020 4:31 pm, edited 1 time in total.
Reason: Prefixed title for more clarity
User avatar
Kunda1
Posts: 7337
Joined: Thu Jan 05, 2017 9:03 pm

Re: New Feature: Notch Connector

Postby Kunda1 » Sat Feb 29, 2020 4:33 pm

This is very cool, as I mentioned in the other thread. Do you mind adding the URL directly to the part of the code in your workbench so devs can access this conveniently?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Posts: 7337
Joined: Thu Jan 05, 2017 9:03 pm

Re: New Feature: Notch Connector

Postby Kunda1 » Sat Feb 29, 2020 11:47 pm

CurveShapes_NotchConnector.svg
NotchConnector logo (very cool logo)
(22.43 KiB) Downloaded 6 times
Code: https://github.com/chbergmann/CurvedSha ... nnector.py
christi wrote:
Sat Feb 29, 2020 3:56 pm
:bell:
There is a dependency on CurvedShapes though?
see https://github.com/chbergmann/CurvedSha ... tor.py#L13
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
christi
Posts: 74
Joined: Wed Oct 24, 2018 7:03 am
Location: Karlsruhe, Germany
Contact:

Re: New Feature: Notch Connector

Postby christi » Sun Mar 01, 2020 6:15 pm

I could do the merging into another workbench. Which one is the best one for this ?
fc_tofu
Posts: 485
Joined: Sun Jan 05, 2020 4:56 pm

Re: New Feature: Notch Connector

Postby fc_tofu » Sun Mar 01, 2020 8:31 pm

christi wrote:
Sun Mar 01, 2020 6:15 pm
I could do the merging into another workbench. Which one is the best one for this ?
fsc_2020-03-02_042310.jpg
fsc_2020-03-02_042310.jpg (61.32 KiB) Viewed 332 times
fsc_2020-03-02_042300.jpg
fsc_2020-03-02_042300.jpg (57.43 KiB) Viewed 332 times
I am not familiar with boolean tools, but there are some under PartWB.

BTW, Icon style need refinement to keep consistent with PartWB tools.
User avatar
Kunda1
Posts: 7337
Joined: Thu Jan 05, 2017 9:03 pm

Re: New Feature: Notch Connector

Postby Kunda1 » Sun Mar 01, 2020 9:03 pm

Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
carlopav
Posts: 1214
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: New Feature: Notch Connector

Postby carlopav » Sun Mar 01, 2020 9:16 pm

fc_tofu wrote:
Sun Mar 01, 2020 8:31 pm
I am not familiar with boolean tools, but there are some under PartWB.
Part is a peculiar wb, It can probably be considered the core of FreeCAD. It is used all around other FreeCAD wbs to generate object shapes. It's really stable due to wmayer conservative policy. I suggest thinking about other workbenches where to insert this tool ;)
follow my experiments on BIM modelling for architecture design
vocx
Posts: 3996
Joined: Thu Oct 18, 2018 9:18 pm

Re: New Feature: Notch Connector

Postby vocx » Mon Mar 02, 2020 6:57 am

https://github.com/vocx-fc/FreeCAD/tree/Notch

I've put it temporarily in the Draft Workbench, src/Mod/Draft, just because I am refactoring commands with a certain style.

So the notch command is three files, a function to create it and an object class in draftobjects/, a GUI command in draftguitools/, and a view provider in draftviewproviders/.

I think this tool makes more sense in some sort of assembly workbench, or woodworking workbench.

I also don't quite understand why it creates two NotchConnector objects. I didn't test enough, I just wanted to test the structure by placing different parts of the code in different directories.
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
User avatar
Kunda1
Posts: 7337
Joined: Thu Jan 05, 2017 9:03 pm

Re: New Feature: Notch Connector

Postby Kunda1 » Mon Mar 02, 2020 8:47 pm

vocx wrote:
Mon Mar 02, 2020 6:57 am
I've put it temporarily in the Draft Workbench, src/Mod/Draft, just because I am refactoring commands with a certain style.
Thanks @vocx
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
yorik
Site Admin
Posts: 11845
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: New Feature: Notch Connector

Postby yorik » Tue Mar 03, 2020 2:27 pm

I think at some point it could indeed go into Part. There are a few other Python tools in Part too. The only thing I guess is that it needs to be very well compacted into its own, independent, as small as possible set of files...