GSoC Proposal: Extended functionality of Rebar Addon

Contributions from the participants, questions and answers to their projects.
Discussions of proposals for upcoming events.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
amrit3701
Posts: 343
Joined: Mon Jun 13, 2016 5:37 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Post by amrit3701 »

Suraj Dadral wrote: Wed Dec 16, 2020 6:30 am Hi @All

The Reinforcement Drawing Dimensioning GUI made by @balrobs is integrated into Rinforcement Workbench as per PR: https://github.com/amrit3701/FreeCAD-Re ... t/pull/119
Will be merged into master branch soon...

Till then, you may test it by getting code from "integrate-drawing-dimensioning-ui" branch from here: https://github.com/SurajDadral/FreeCAD- ... sioning-ui


ShapeUi.png
DrawingUi.png
DimensionUI1.png
DimensionUI2.png
DimensionUI3.png
Amazing stuff @Suraj. :)
Amritpal Singh
Github, Like my work, sponsor me!
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Post by balrobs »

Suraj Dadral wrote: Wed Dec 16, 2020 6:30 am The Reinforcement Drawing Dimensioning GUI made by @balrobs is integrated into Rinforcement Workbench as per PR: https://github.com/amrit3701/FreeCAD-Re ... t/pull/119
Will be merged into master branch soon...
Hi @Suraj, any reason why the lastest PR is still waiting to be merged?
User avatar
Suraj Dadral
Posts: 307
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: GSoC Proposal: Extended functionality of Rebar Addon

Post by Suraj Dadral »

balrobs wrote: Mon Jan 18, 2021 12:49 pm Hi @Suraj, any reason why the lastest PR is still waiting to be merged?
Hi @balrobs

The PR is merged. It was not merged because when I tested at that time, Reinforcement Dimensioning was not generated and I thought there maybe something wrong in new PR. But, I tested now again and everything seems working as expected. So, merged.
Thanks for the ping.
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Post by balrobs »

Suraj Dadral wrote: Mon Jan 18, 2021 3:25 pm
balrobs wrote: Mon Jan 18, 2021 12:49 pm Hi @Suraj, any reason why the lastest PR is still waiting to be merged?
Hi @balrobs

The PR is merged. It was not merged because when I tested at that time, Reinforcement Dimensioning was not generated and I thought there maybe something wrong in new PR. But, I tested now again and everything seems working as expected. So, merged.
Thanks for the ping.
Wonderfull! Now everyone can update and use the lastest improvements :D
Post Reply