I will add recompute at appropriate place in next commit.balrobs wrote: ↑Wed Jul 29, 2020 1:55 pmI've testet your lastest code ... Wonderful progress!
Here are some more considerations:
- I noticed that after the creation of the drawings, labels/dimensions have a wrong position ... they are translated from the structure element. BTW a "recompute" or F5 realigns them properly.
For now, proceeding as suggested by @amrit3701, but created issue here regarding same to do it later.balrobs wrote: ↑Wed Jul 29, 2020 1:55 pm
- I think it would be usefull if labels/dimensions that belong to parallel laid reinforcements (i.e. mark m1 in following esample) could show also their mutual distance. Maybe this could be done by extending the dimension format from "%M %C⌀%D" to something like this "%M %C⌀%D, a=%I"
If WayPointsType is set to "Automatic", then dimension line points will be calculated automatically for each rebar. But, if it is set to "Custom", then user can also specify the dimension line points in property "WayPoints", thus giving capability to user to edit rebar dimensioning.
I have one good news for you and for @All here.
I manually added RebarShape property to each rebar object and assigned them rebar type which best matches with one of the rebar types supported by Reinforcement workbench.
So, in future, we can also create a function to do above job automatically, thus extending support for custom rebars. And created issue regarding same here.
Here is modified model with reinforcement drawing and dimensioning:
The problem is, we are using Draft.getSVG() function to create drawing of custom rebars. And that function is returning empty value for some cutom rebars.
So, did some exception handing as per this commit: https://github.com/SurajDadral/FreeCAD- ... a5f74c398f