GSoC Proposal: Extended functionality of Rebar Addon

A forum dedicated to the Draft, Arch and BIM workbenches development.
User avatar
Suraj Dadral
Posts: 304
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby Suraj Dadral » Wed Nov 04, 2020 6:17 pm

balrobs wrote:
Wed Nov 04, 2020 7:37 am
Here is the second part with the next two secondary dialogs ...
ReinforcementDrawingAndDimensioning_Dimensions1.ui
Main_Dimensions1.png
ReinforcementDrawingAndDimensioning_Dimensions2.ui
Main_dimensions2.png
Edit: Will upload my last dialog soon, Cheers! :D
Great work so far @balrobs

Feel free to create PR to FreeCAD-Reinforcement github repository with your dialog boxes and ping me if you need any help regarding same.

Thanks,
balrobs
Posts: 177
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby balrobs » Wed Nov 04, 2020 6:50 pm

Suraj Dadral wrote:
Wed Nov 04, 2020 6:17 pm
Feel free to create PR to FreeCAD-Reinforcement github repository with your dialog boxes and ping me if you need any help regarding same.
Hi @Suraj
Here is my last secondary dialog ...
Main_Dimensions3.png
Main_Dimensions3.png (71.78 KiB) Viewed 448 times
Hope my work helps 8-)
Since I only have very rudimentary programming skills, I've only implemented the graphical part of the dialogs. All the logic behind it is still missing.
So far I haven't dealt with github, so I would be happy if you could do the PR for me.
Maybe some day with better programming knowledges I will learn to use github too.
Thank you for your helpfulness
User avatar
bernd
Posts: 11096
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby bernd » Wed Nov 04, 2020 8:48 pm

if you only change one file you do not need to run local git you could doe everything with github. Means this would be a good example to give it a try. Even if you have more than one, you could still just add one dialogbox in every new commit.

- get a github account, log into github
- go to the repository you would like to make a PR on
- click on the fork button, the fork of the repo will be copied into your github
- got to your new repo
- the master branch (might be named main newly), is standard
- use the branch selector, put in a name, you will be ask to create a new branch, give it a nam
- use github to upload your new file into the repo and commit the change
- stay logged in and go to the origin repo to PullRequests
- github will recognise your repo with the new branch with changes (some green button)
- just hit the greeen button "compare and PullReques" and make a PR
- wait for the PR to be merged

- all written out of my head, I have done it hundred times, but did not do it just now. Means sometimes it could be slightly different.

BTW: git is a beast, but if you domesticate the beast you will never give it away again.
User avatar
bernd
Posts: 11096
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby bernd » Wed Nov 04, 2020 8:52 pm

If you have problems try it again, or ask here. We will make a official Reinforcement Workbench developer out of you :D
balrobs
Posts: 177
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby balrobs » Wed Nov 04, 2020 9:30 pm

bernd wrote:
Wed Nov 04, 2020 8:52 pm
If you have problems try it again, or ask here. We will make a official Reinforcement Workbench developer out of you :D
:lol: Thanks for your help @Bernd. I will give it a try soon when I have some more time.
Cheers!
balrobs
Posts: 177
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby balrobs » Wed Nov 04, 2020 10:05 pm

Suraj Dadral wrote:
Wed Nov 04, 2020 6:02 pm
... I tried reproducing above issue, but not able to maybe because I am not able to understand the issue properly ...
Hi @Suraj,
I made a screencast for helping you understand the issue.
https://drive.google.com/file/d/1nealco ... sp=sharing
balrobs
Posts: 177
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby balrobs » Thu Nov 05, 2020 2:14 pm

bernd wrote:
Wed Nov 04, 2020 8:48 pm
BTW: git is a beast, but if you domesticate the beast you will never give it away again.
Hi @Bernd,
my first meeting with the beast wasn't that bad at all. It made a pretty good impression to me :lol:
Now I'm waiting for my PR to be accepted!
Thank you for your guidance!
User avatar
bernd
Posts: 11096
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby bernd » Fri Nov 06, 2020 1:59 pm

balrobs wrote:
Thu Nov 05, 2020 2:14 pm
bernd wrote:
Wed Nov 04, 2020 8:48 pm
BTW: git is a beast, but if you domesticate the beast you will never give it away again.
Hi @Bernd,
my first meeting with the beast wasn't that bad at all. It made a pretty good impression to me :lol:
Now I'm waiting for my PR to be accepted!
Thank you for your guidance!
great ... keep up ... there can be done a lot of small stuff with the github gui. For reference the PR https://github.com/amrit3701/FreeCAD-Re ... t/pull/118 and of course you are an official dev now https://github.com/amrit3701/FreeCAD-Re ... ntributors :)
The master branch of your repo is behind the main Reinforcement repo. You should make your master branch to be uptodat with the main Reinforment branch of amrit again. But AFAIK this is not possible ATM in github. You would need to do it with git on you local machine and push it back to github. The beast is trying to bit you once again :mrgreen: There are hundreds of tutorials ... may be tow of them here ... Source_code_management https://docs.github.com/en/free-pro-tea ... repository

- install some git on your local machine
- clone your repo from your github
- add amrits repo as a remote
- fetch the remote
- merge the master of amrite into your master branch
- push the chaches back to your github
balrobs
Posts: 177
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby balrobs » Sat Nov 07, 2020 10:33 am

Thanks @Bernd,
Lots of things to learn :? . Hope I can find some time to dig deeper so that I can better contribute to further development in the future.
balrobs
Posts: 177
Joined: Fri Apr 24, 2020 8:58 pm

Rebar Addon And

Postby balrobs » Thu Nov 19, 2020 2:22 pm

Hi to everyone,
I found another area where IMHO the reinforcement workbench could be improved. Lately I tested it with geometries (columns and beams) linked to other files with the App:Link command (see attached file: structures at the left site are saved in the file, those at the right site are linked to other files).
I noticed that stirrups for linked beams and columns are generated but not the longitudinal bars which depends on sketches. Those sketches report this error messages: AttachEngine3D: link points to something that is not App:GeoFeature
Screenshot from 2020-11-19 14-37-39.png
Screenshot from 2020-11-19 14-37-39.png (359.37 KiB) Viewed 171 times
Here my original test files an my system info:

Code: Select all

OS: Ubuntu 20.04.1 LTS (ubuntu:GNOME/ubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Branch: unknown
Hash: aabff60388a4434388c267390b6fb7c9212d5091
Python version: 3.8.5
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.3.0
Locale: English/United States (en_US)
Attachments
beam.FCStd
(6.86 KiB) Downloaded 5 times
columns.FCStd
(9.86 KiB) Downloaded 5 times
reinforcement_beam_column.FCStd
(324.48 KiB) Downloaded 6 times