Dialog Improvements for Reinforcement WB

[balrobs]

Hello,
when using the Reinforcement Workbench with dark stylesheets (Edit-> Preferences-> General-> stylesheet: dark ....) I discovered problems with some dialogs. Most of them work fine as shown in the image below:

straight_rebar.png (155.04 KiB) Viewed 1532 times

but those for generating Column Reinforcement:

column_reinforcement.png (187.28 KiB) Viewed 1532 times

and Beam Reinforcement:

beam_reinforcement.png (220.28 KiB) Viewed 1532 times

seems to have problems.
Cheers

[balrobs]

Hello,
when using the Reinforcement Workbench with dark stylesheets (Edit-> Preferences-> General-> stylesheet: dark ....) I discovered problems with some dialogs. Most of them work fine as shown in the image below:
straight_rebar.png
but those for generating Column Reinforcement:
column_reinforcement.png
and Beam Reinforcement:
beam_reinforcement.png
seems to have problems.
Cheers

Edit:
Sorry, I forgot my system info:

Code: Select all

OS: Ubuntu 20.04.1 LTS (ubuntu:GNOME/ubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Branch: unknown
Hash: 1ef31842c921dcb8a4e2045dc5664e509e4b25f2
Python version: 3.8.2
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.3.0
Locale: English/United States (en_US)

[vocx]

when using the Reinforcement Workbench with dark stylesheets

The Reinforcement Workbench is an Addon; it is not part of the base FreeCAD system. Try contacting its author to address your question directly to him.

[balrobs]

when using the Reinforcement Workbench with dark stylesheets

The Reinforcement Workbench is an Addon; it is not part of the base FreeCAD system. Try contacting its author to address your question directly to him.

Thank you @vocx for your reply. Will try to contact the author in the dedicated forum topic.

[amrit3701]

Thank you @vocx for your reply. Will try to contact the author in the dedicated forum topic.

Issue created: https://github.com/amrit3701/FreeCAD-Re ... issues/104

I will let you know once issue resolve.

Cheers,

[Suraj Dadral]

This issue has been fixed partially as per PR: https://github.com/amrit3701/FreeCAD-Re ... t/pull/106

Now, everything looks fine except images in dialog:

BeamReinforcementUi.PNG (91.79 KiB) Viewed 1247 times

ColumnReinforcementUi.PNG (45.09 KiB) Viewed 1247 times

So, created issue for same here: Need svg images for column and beam reinforcement dialog

Thanks,

[balrobs]

This issue has been fixed partially as per PR: https://github.com/amrit3701/FreeCAD-Re ... t/pull/106

Now, everything looks fine except images in dialog:
BeamReinforcementUi.PNG
ColumnReinforcementUi.PNG

So, created issue for same here: Need svg images for column and beam reinforcement dialog

Thanks,

Hi @Suraj,

thank you so much for your quick fix
I've tried to produce a starting point for the missing svg-files by using Techdraw and cleaning them a bit with Inkscape:

CircularColumnReinforcement.svg

(43.06 KiB) Downloaded 36 times

Column_SingleTieMultipleRebars.svg

(87 KiB) Downloaded 41 times

Column_TwoTiesSixRebars.svg

(86.21 KiB) Downloaded 35 times

The files don't yet contain any colors since I'm not sure which of them fit best with light and dark themes.
I also didn't add any texts because I'm not sure how to best deal with internationalization.

PS: The image for Beam_TwoLeggedStirrups.png is still missing. I will try to make something similar to this soon when I find some time.

[balrobs]

PS: The image for Beam_TwoLeggedStirrups.png is still missing. I will try to make something similar to this soon when I find some time.

As promised the missing svg image.I hope it can be usefull

Beam_TwoLeggedStirrups.zip

(173.03 KiB) Downloaded 37 times

Cheers