[ Comments Request /PR ] Intuitive Automatic Windows/Doors + Equipment Placement

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by balrobs »

paullee wrote: Thu Jan 21, 2021 6:34 pm So, in nutshell, Recompute the Link (with a mark indicating pending Recompute), before initiating the AttachToEdge Tool.
Yet to look if this can be avoided with codes, please file an Issue in GitHub if you can help. Thanks testing and debugging. :D
Exactly that was the problem! Thank you @paullee for pointing it out :D
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by balrobs »

paullee wrote: Thu Jan 21, 2021 6:34 pm please file an Issue in GitHub if you can help. Thanks testing and debugging. :D
Added issue https://github.com/paullee0/FreeCAD_SketchArch/issues/6 to Github.
paullee
Veteran
Posts: 5092
Joined: Wed May 04, 2016 3:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by paullee »

balrobs wrote: Fri Jan 22, 2021 7:53 am
paullee wrote: Thu Jan 21, 2021 6:34 pm please file an Issue in GitHub if you can help. Thanks testing and debugging. :D
Added issue https://github.com/paullee0/FreeCAD_SketchArch/issues/6 to Github.

Should works without user intervention now.

The tool would recompute the target Link if found it is not properly set up yet.


SketchArch WB / Python Updated
  1. SketchArch WB in https://github.com/paullee0/FreeCAD_SketchArch
  2. If you have previous files, simply replace below file
    ArchSketchObject.py
    (65.1 KiB) Downloaded 88 times
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by balrobs »

paullee wrote: Tue Feb 02, 2021 12:29 am ...
Should works without user intervention now.
The tool would recompute the target Link if found it is not properly set up yet.
...
Just great! :D
I tested your fix and it works like expected.
Thank you man for your amazing work!
paullee
Veteran
Posts: 5092
Joined: Wed May 04, 2016 3:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by paullee »

Just come to my attention there is some fundamental flaw - When the Base Sketch of the Wall is ordinary Sketch, i.e. not ArchSketch, nothing works, Report View return errors :shock:

That is not the intention. Running more trial to verify, anyone has similar problem?


Probably using ArchSketch become my habit so I never test this usecase.
Screenshot from 2021-02-06 17-26-14.png
Screenshot from 2021-02-06 17-26-14.png (294.4 KiB) Viewed 2225 times
paullee
Veteran
Posts: 5092
Joined: Wed May 04, 2016 3:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by paullee »

paullee wrote: Sat Feb 06, 2021 9:29 am Just come to my attention there is some fundamental flaw - When the Base Sketch of the Wall is ordinary Sketch, i.e. not ArchSketch, nothing works, Report View return errors :shock:

That is not the intention. Running more trial to verify, anyone has similar problem?
Should works with Ordinary Sketch as Base of Wall now, see anyone interested in testing :D

SketchArch WB / Python Updated
  1. SketchArch WB in https://github.com/paullee0/FreeCAD_SketchArch
  2. If you have previous files, simply replace below file
    ArchSketchObject.py
    (65.8 KiB) Downloaded 46 times
Example Model File for Testing
Screenshot from 2021-02-07 04-00-56.png
Screenshot from 2021-02-07 04-00-56.png (247.67 KiB) Viewed 2205 times
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by balrobs »

paullee wrote: Sat Feb 06, 2021 9:29 am Just come to my attention there is some fundamental flaw - When the Base Sketch of the Wall is ordinary Sketch, i.e. not ArchSketch, nothing works, Report View return errors :shock:

That is not the intention. Running more trial to verify, anyone has similar problem?


Probably using ArchSketch become my habit so I never test this usecase.

Screenshot from 2021-02-06 17-26-14.png
Hi @paullee,
I had the same habit so I never realized the problem too :evil:
BTW you were right ... before your update ordinary Sketches had problems, with your latest update the problems are gone!
Thanks for finding and solving the issue :D
paullee
Veteran
Posts: 5092
Joined: Wed May 04, 2016 3:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by paullee »

balrobs wrote: Sun Feb 07, 2021 10:31 am BTW you were right ... before your update ordinary Sketches had problems, with your latest update the problems are gone!
Thanks for finding and solving the issue :D
Thanks for testing :) Some features may eventually need ArchSketch for ease of implementation maybe.

One of the goal is able for an ArchObject to attach to an ArchSpace, which is in turned formed / defined by a numbers of ArchWall. Then one can tell, e.g. which windows are in which Room (Space), which furnitures etc...

Maybe would expose the feature to attach to Intersection of Wall, rather then just along 1 wall at the moment.
paullee
Veteran
Posts: 5092
Joined: Wed May 04, 2016 3:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by paullee »

OK, one more feature to ease placement.

Placement Offsetting from Intersection of Walls
(rather than from end of Walls)
  1. Currently Arch Object can offset from one end of Wall - ScreenCapture-1
    (with MasterSketch SubElement + MasterSketch Subelement Offset setting)
  2. Would be difficult to calculate exact length if one would like to offset from the intersection of 2 Walls - ScreenCapture-2
  3. Input int MasterSketch Intersecting Subelement, in this case 6 - ScreenCapture-3
  4. Now the ArchObject offset from their intersecting point
  5. More cool is a Construction Edge in Sketch is supported
  6. Input int MasterSketch Intersecting Subelement, in this case 5 - ScreenCapture-4
May better to have the SketchArch GUI Edit Attachment to support this :)
Even better to implement 'Attaching to a Room' rather than just Wall :D

SketchArch WB
  1. SketchArch WB in https://github.com/paullee0/FreeCAD_SketchArch
Example Model File for Testing
Test_ Link_ ArchWindow_ 04k.FCStd
(595.22 KiB) Downloaded 58 times

Screenshot from 2021-02-21 06-37-15.png
Screenshot from 2021-02-21 06-37-15.png (258.78 KiB) Viewed 2038 times
Screenshot from 2021-02-21 06-37-57.png
Screenshot from 2021-02-21 06-37-57.png (261.03 KiB) Viewed 2038 times
Screenshot from 2021-02-21 06-38-25.png
Screenshot from 2021-02-21 06-38-25.png (258.6 KiB) Viewed 2038 times
Screenshot from 2021-02-21 06-39-28.png
Screenshot from 2021-02-21 06-39-28.png (305.91 KiB) Viewed 2038 times
paullee
Veteran
Posts: 5092
Joined: Wed May 04, 2016 3:58 pm

Re: [ Comments Request ] Intuitive Automatic Windows/Doors + Equipment Placement

Post by paullee »

balrobs wrote: Sat Jan 02, 2021 1:39 pm
paullee wrote: Sat Jan 02, 2021 10:23 am Another are fine-tuning behaviour of current parameters themselves, better names, user expectation of behaviours - e.g. 'Flip Offset Origin to Other End' allows attachment, instead to the Starting Point of a Sketch Edge, to End Point of the edge. Currently it would also rotate the attaching object by 180 deg. But should it also jump from one face of the wall to opposite face ?
IMHO it makes more sense if it wouldn't jump to the opposite face side.
Changing the parameter "FlipOffsetOriginToOtherEnd" I would only expect the offset origin to change.
In order to change wall face site it's more intuitive to alter the "Attachment Aligment" parameter from "EdgeGroupWidthLeft" to "EdgeGroupWidthRight" and viceversa.
Update behaviour accordingly :D

SketchArch WB
Update the addon by dowloading at github or simply replace below file
  1. SketchArch WB in https://github.com/paullee0/FreeCAD_SketchArch
  2. ArchSketchObject.py
    (66.02 KiB) Downloaded 40 times
Example Model File for Testing
Test_ Link_ ArchWindow_ 04n.FCStd
(600.62 KiB) Downloaded 36 times



phpBB [video]
Post Reply