LGTM code analysis regarding ArchRoof.py

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

LGTM code analysis regarding ArchRoof.py

Post by Kunda1 »

Per LGTM
This line is problematic. According to the blame info it was introduced by @Roy_043
Roy_043 wrote: pinged by pinger macro
@Roy_043 care to take a peek? Thanks!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Roy_043
Veteran
Posts: 8409
Joined: Thu Dec 27, 2018 12:28 pm

Re: LGTM code analysis regarding ArchRoof.py

Post by Roy_043 »

It is really a false positive. But I can rewrite the function in question to avoid the issue.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: LGTM code analysis regarding ArchRoof.py

Post by Kunda1 »

Roy_043 wrote: Tue Feb 23, 2021 5:13 pm It is really a false positive. But I can rewrite the function in question to avoid the issue.
Yea, it looked like it one. If you don't mind, that would be great :D
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Roy_043
Veteran
Posts: 8409
Joined: Thu Dec 27, 2018 12:28 pm

Re: LGTM code analysis regarding ArchRoof.py

Post by Roy_043 »

User avatar
Roy_043
Veteran
Posts: 8409
Joined: Thu Dec 27, 2018 12:28 pm

Re: LGTM code analysis regarding ArchRoof.py

Post by Roy_043 »

Kunda1 wrote: Tue Feb 23, 2021 4:56 pm the blame info
I'd be interested in knowing how you can find this information.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: LGTM code analysis regarding ArchRoof.py

Post by Kunda1 »

Roy_043 wrote: Tue Feb 23, 2021 7:04 pm
Kunda1 wrote: Tue Feb 23, 2021 4:56 pm the blame info
I'd be interested in knowing how you can find this information.
Several ways, normally on github you can use the 'blame' button
On any github page that has code on it the 'blame' button is available to use
On any github page that has code on it the 'blame' button is available to use
FreeCAD-github-blame.png (15.36 KiB) Viewed 1161 times
with LGTM you can click the commit hash:
Click the hash to see who added it
Click the hash to see who added it
freecad-lgtm-blame.png (38.88 KiB) Viewed 1161 times
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Roy_043
Veteran
Posts: 8409
Joined: Thu Dec 27, 2018 12:28 pm

Re: LGTM code analysis regarding ArchRoof.py

Post by Roy_043 »

Thanks.
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: LGTM code analysis regarding ArchRoof.py

Post by bernd »

wow never tried this blame button in github :o this is great, very, very, very useful.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: LGTM code analysis regarding ArchRoof.py

Post by Kunda1 »

bernd wrote: Wed Feb 24, 2021 10:21 am wow never tried this blame button in github :o this is great, very, very, very useful.
Well, in that case, I guess it's worth mentioning on the github wiki page.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply