Makeblocks not working

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
elsordo
Posts: 70
Joined: Sat Jan 30, 2016 6:34 am

Makeblocks not working

Post by elsordo »

I have in interesting problem. I can no longer compute the block for a wall. I get the error that the wall has an invalid shape. I have attached the test case and pictures.

The version info is

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24267 (Git)
Build type: Release
Branch: master
Hash: b2ca86d8d72b636011a73394bf9bcdedb3b109b7
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)

Attached is the report view, the combo view and the model.
The MainView window
The MainView window
MainView.png (65.71 KiB) Viewed 1652 times
Attachments
The Report View
The Report View
ReportView.png (9.04 KiB) Viewed 1652 times
BlockBug.FCStd
The model
(13.29 KiB) Downloaded 54 times
The ComboView showing the offending wall
The ComboView showing the offending wall
ComboView.png (32.85 KiB) Viewed 1652 times
paullee
Veteran
Posts: 5130
Joined: Wed May 04, 2016 3:58 pm

Re: Makeblocks not working

Post by paullee »

elsordo wrote: Sun Feb 28, 2021 2:34 am I have in interesting problem. I can no longer compute the block for a wall. I get the error that the wall has an invalid shape. I have attached the test case and pictures.
Not quite familiar with Make Block, seems always need Joint to be some figure > 0mm to work :)

Screenshot from 2021-02-28 10-52-50.png
Screenshot from 2021-02-28 10-52-50.png (191.6 KiB) Viewed 1644 times
elsordo
Posts: 70
Joined: Sat Jan 30, 2016 6:34 am

Re: Makeblocks not working

Post by elsordo »

Hmmm, this is new behavior. I have been using a zero thickness joint which would apply to dry stack masonry that is surface bonded.

Why was a non-zero thickness joint enforced?
User avatar
Roy_043
Veteran
Posts: 8576
Joined: Thu Dec 27, 2018 12:28 pm

Re: Makeblocks not working

Post by Roy_043 »

Joints can be zero. That does not explain the problem. My guess is that the code does not take into account that there can be rounding errors when working with floats. With the given data an attempt is made to add a (almost) zero height layer of blocks at the top of the wall. You would expect 28 block, but Instead there are 32.

Code: Select all

>>> 7*203.2
1422.3999999999999
>>> 7*203.2 == 1422.4
False
elsordo
Posts: 70
Joined: Sat Jan 30, 2016 6:34 am

Re: Makeblocks not working

Post by elsordo »

Is there any chance of getting this fixed?
paullee
Veteran
Posts: 5130
Joined: Wed May 04, 2016 3:58 pm

Re: Makeblocks not working

Post by paullee »

Oh rounding tolerence. That probably can be fixed by @Roy_043 ? :D
User avatar
Roy_043
Veteran
Posts: 8576
Joined: Thu Dec 27, 2018 12:28 pm

Re: Makeblocks not working

Post by Roy_043 »

As a workaround use this expression for the height of the wall:
56in
elsordo
Posts: 70
Joined: Sat Jan 30, 2016 6:34 am

Re: Makeblocks not working

Post by elsordo »

I think that the error is deeper than just a rounding problem.

I downloaded the above FCSTD file to my Ubuntu box and tried to make some blocks but I found a different error. It looks like there is an exception.

I have attached the Combo View, Report View, and Python Console View
ReportView.png
ReportView.png (32.47 KiB) Viewed 1371 times
PythonConsole.png
PythonConsole.png (68.93 KiB) Viewed 1371 times
ComboView.png
ComboView.png (58.41 KiB) Viewed 1371 times
The FreeCAD version info is

OS: Ubuntu 20.04.2 LTS (ubuntu:GNOME/ubuntu-wayland)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24267 (Git) AppImage
Build type: Release
Branch: master
Hash: b2ca86d8d72b636011a73394bf9bcdedb3b109b7
Python version: 3.8.6
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)
User avatar
Roy_043
Veteran
Posts: 8576
Joined: Thu Dec 27, 2018 12:28 pm

Re: Makeblocks not working

Post by Roy_043 »

You are not providing new information. Just compare Paullee's screenshot.
Have you tried the proposed workaround?
elsordo
Posts: 70
Joined: Sat Jan 30, 2016 6:34 am

Re: Makeblocks not working

Post by elsordo »

Roy_043 wrote: Wed Mar 10, 2021 4:34 pm You are not providing new information. Just compare Paullee's screenshot.
Have you tried the proposed workaround?
For both Ubuntu and Windows 10, I downloaded the model that I had posted to the topic and then I tried 56" for the wall height but the property editor promptly converted it to 4' 8" and still complains about an invalid shape.

Why does Ubuntu give me a different error message than Windows10

-David
Post Reply