[ Bug ] "Show Fill" in ArchView-TechDraw no longer works

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

[ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by paullee »

It seems Show Fill set to True no longer works for ArchWall in TechDraw with ArchView :)

Tested with below AppImages on Fedora 31

Not Working
FreeCAD_0.19-24276-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-23756-Linux-Conda_glibc2.12-x86_64.AppImage

Working
FreeCAD_0.19-23578-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-23258-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-21775-Linux-Conda_glibc2.12-x86_64.AppImage

Screenshot from 2021-04-08 05-11-58.png
Screenshot from 2021-04-08 05-11-58.png (229.35 KiB) Viewed 2843 times
Screenshot from 2021-04-08 05-12-02.png
Screenshot from 2021-04-08 05-12-02.png (261.34 KiB) Viewed 2843 times

OS: Fedora 31 (Workstation Edition) (GNOME/gnome)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24276 (Git)
Build type: Release
Branch: (HEAD detached at 0.19.1)
Hash: a88db11e0a908f6e38f92bfc5187b13ebe470438
Python version: 3.8.8
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)


OS: Fedora 31 (Workstation Edition) (GNOME/gnome)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.23756 (Git) AppImage
Build type: Release
Branch: master
Hash: 9c6e9184930a52b165a0b7274e3a45d1006bfe67
Python version: 3.8.6
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)


OS: Fedora 31 (Workstation Edition) (GNOME/gnome)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.23578 (Git) AppImage
Build type: Release
Branch: master
Hash: 50c3cbf00579dc4941ca743c25720d016b0453ce
Python version: 3.8.6
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by bitacovir »

paullee wrote: Wed Apr 07, 2021 9:27 pm It seems Show Fill set to True no longer works for ArchWall in TechDraw with ArchView
I confirm with FC 0.20 in windows

OS: Windows 10 Version 1909
Word size of FreeCAD: 64-bit
Version: 0.20.24587 (Git)
Build type: Release
Branch: master
Hash: 1f62d4666102d8efd4d8f3ba58a1037456a3bcfb
Python version: 3.8.6+
Qt version: 5.15.1
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/United States (en_US)
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by Syres »

paullee wrote: Wed Apr 07, 2021 9:27 pm It seems Show Fill set to True no longer works for ArchWall in TechDraw with ArchView :)
The commit that appears to have caused the regression is git commit d7692e3 so I think @yorik would need to be involved in a fix so what he was trying to achieve isn't re-broken!! Copying the old ArchSectionPlane.py over the new one worked for me, what confused me on testing was that when I opened your file ArchView was set to Wireframe and not Solid.
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by bitacovir »

I left a message in the commit linking to this thread. If Yorik is too busy we just could leave a report in the bugtracker.
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by Syres »

All I did was change line 456 of src\Mod\Arch\ArchSectionPlane.py from:

Code: Select all

            svgcache += render.getSectionSVG(linewidth="SVGCUTLINEWIDTH",fillpattern="#ffffff")
which is pure white (and so looks like it's not working but it is really) to:

Code: Select all

            svgcache += render.getSectionSVG(linewidth="SVGCUTLINEWIDTH",fillpattern="#d6d6d6")
which is the same as 'sectionfill' but I suppose unless we know what the exact fault was that caused the change then we won't know if a PR is worth raising.
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by paullee »

Probably @Yorik want to achieve to use colour of the object for the fill colour (announced somewhere and probably in wikj) he did the change ?

And Solid is kind of buggy to my memory as @Yorik explained.

On the move, see what we can do later.

Probably ping him or leave a bug report :D
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by paullee »

p.s.

Now it make sense -

So if the Wall / Object colour is white (or same colour as TechDraw background) i.e. White, it should default to say Gray, otherwise the current regression.
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by paullee »

Syres wrote: Thu Apr 08, 2021 1:29 pm which is pure white (and so looks like it's not working but it is really) to:

Code: Select all

            svgcache += render.getSectionSVG(linewidth="SVGCUTLINEWIDTH",fillpattern="#d6d6d6")
Without attempt to check the code :), I do further test:-
  1. A Material is created with name of 'Concrete'
  2. Color is Red, Section Colour is Blue
  3. Assign to the Wall object
  4. Workaround some Recompute bugs (e.g. needs turn on Fuse Arch, and turn it off to trigger 'real compute')
  5. Now ArchView show Section Colour :D
Screenshot from 2021-04-09 07-38-37.png
Screenshot from 2021-04-09 07-38-37.png (273.88 KiB) Viewed 2640 times
Screenshot from 2021-04-09 07-38-56.png
Screenshot from 2021-04-09 07-38-56.png (278.78 KiB) Viewed 2640 times
Screenshot from 2021-04-09 07-39-04.png
Screenshot from 2021-04-09 07-39-04.png (268.1 KiB) Viewed 2640 times
Screenshot from 2021-04-09 07-40-11.png
Screenshot from 2021-04-09 07-40-11.png (264.43 KiB) Viewed 2640 times
User avatar
Carlos Alberto
Posts: 10
Joined: Thu Mar 18, 2021 3:49 pm
Location: Colombia
Contact:

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by Carlos Alberto »

paullee wrote: Wed Apr 07, 2021 9:27 pm It seems Show Fill set to True no longer works for ArchWall in TechDraw with ArchView :)

Tested with below AppImages on Fedora 31

Not Working
FreeCAD_0.19-24276-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-23756-Linux-Conda_glibc2.12-x86_64.AppImage

Working
FreeCAD_0.19-23578-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-23258-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-21775-Linux-Conda_glibc2.12-x86_64.AppImage
I had the same problem, till I noticed there is a "fill" but it is white, so it's not visible on a white paper background.

I solved it this way:
[*]Create an Arch Mateiral
[*]In the tree view there will appear a group "Materials", double click your recently created material
[*]You'll find options "Color" and "Section Color", select a color for "Section Color" different to white
[*]Assign that material to the walls of your model in the Data Section
[*]Now in the TechDraw ArchView the fill showing will be the Section Color you select for the material

Hope this will help you.

(Using the FreeCAD Stable PPA)
OS: Linux Mint 20.1 (X-Cinnamon/cinnamon)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Branch: unknown
Hash: 9e3b630bbfb6807e93eeffb655e6c20f218644fc
Python version: 3.8.5
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.5.1
Locale: English/United States (en_US)
Arch. Carlos Alberto
Architecture + 3D Animation
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Post by bitacovir »

Carlos Alberto wrote: Tue Apr 27, 2021 1:09 am
I solved it this way:
[*]Create an Arch Mateiral
[*]In the tree view there will appear a group "Materials", double click your recently created material
[*]You'll find options "Color" and "Section Color", select a color for "Section Color" different to white
[*]Assign that material to the walls of your model in the Data Section
[*]Now in the TechDraw ArchView the fill showing will be the Section Color you select for the material

Hope this will help you.
Thanks for the tip.
I wrote a report in the bugtraker, anyway.
https://tracker.freecadweb.org/view.php?id=4646
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Post Reply