[ Fixed ] [ Bug ] Draft_PathArray edge selection order problem

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Roy_043
Veteran
Posts: 8409
Joined: Thu Dec 27, 2018 12:28 pm

[ Fixed ] [ Bug ] Draft_PathArray edge selection order problem

Post by Roy_043 »

For a Draft_PathArray it is possible to select edges for the path. They must belong to the same object, they must be connected, and they must be selected in the correct order. The last restriction is a bug IMO.

Selection order:
BL: Edge1, Edge2, Edge3, Edge4. Correct order.
TL: Edge1, Edge4, Edge3, Edge2.
BR: Edge4, Edge1. Correct order.
TR: Edge1, Edge4.

Code: Select all

OS: Windows 8.1 Version 6.3 (Build 9600)
Word size of FreeCAD: 64-bit
Version: 0.20.24986 (Git)
Build type: Release
Branch: master
Hash: ff6845e2f31988cc714027980e0100bb5521843e
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.0
Locale: Dutch/Netherlands (nl_NL)
Attachments
Draft_PathArray-edge-selection-order-problem.png
Draft_PathArray-edge-selection-order-problem.png (15.5 KiB) Viewed 1336 times
Draft_PathArray-edge-selection-order-problem.FCStd
(20.4 KiB) Downloaded 39 times
Last edited by Roy_043 on Sun Aug 01, 2021 4:04 pm, edited 1 time in total.
User avatar
Roy_043
Veteran
Posts: 8409
Joined: Thu Dec 27, 2018 12:28 pm

Re: [ Bug ] Draft_PathArray edge selection order problem

Post by Roy_043 »

This is probably not that hard to solve. But I wonder what would be the 'standard' Draft approach to address such an issue? Where do you validate user input:
...\Mod\Draft\draftguitools\gui_patharray.py
...\Mod\Draft\draftobjects\patharray.py
User avatar
Roy_043
Veteran
Posts: 8409
Joined: Thu Dec 27, 2018 12:28 pm

Re: [ Bug ] Draft_PathArray edge selection order problem

Post by Roy_043 »

https://github.com/FreeCAD/FreeCAD/pull/4899

The PR only fixes the issue, but does not address the validation of user input.
User avatar
Roy_043
Veteran
Posts: 8409
Joined: Thu Dec 27, 2018 12:28 pm

Re: [ Bug ] Draft_PathArray edge selection order problem

Post by Roy_043 »

Merged.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: [ Fixed ] [ Bug ] Draft_PathArray edge selection order problem

Post by Kunda1 »

Thank you!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply