[ Fixed by marioalexis ] Draft Workingplane: projectPoint issue
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Draft Workingplane: projectPoint issue
I was aware that the existing function was overly complex, but I have to admit that my vector math skills are not that great. I'll have to study your suggestion. Note that the dot product can become zero or almost zero. You would need to catch that.
-
- Posts: 124
- Joined: Wed Jun 19, 2019 7:44 pm
Re: Draft Workingplane: projectPoint issue
Yes. To avoid unnecessary check in the most common case when direction is None, the check could be done only if direction is not None.
The value for the projection is derived from the implicit equation of a plane and the parametric equation of a line.
(proj - position)·axis = 0
proj(λ) = p + λ.direction
The value for the projection is derived from the implicit equation of a plane and the parametric equation of a line.
(proj - position)·axis = 0
proj(λ) = p + λ.direction
Re: Draft Workingplane: projectPoint issue
I definitely do not understand that.
-
- Posts: 124
- Joined: Wed Jun 19, 2019 7:44 pm
Re: Draft Workingplane: projectPoint issue
here is an explanation: https://en.wikipedia.org/wiki/Line%E2%8 ... braic_form
Re: Draft Workingplane: projectPoint issue
Thanks for the link. More to study...
-
- Posts: 124
- Joined: Wed Jun 19, 2019 7:44 pm
Re: Draft Workingplane: projectPoint issue
If you want test this @Roy_043 : https://github.com/FreeCAD/FreeCAD/pull/5307
Re: Draft Workingplane: projectPoint issue
I have commented in the PR. Thanks for the fix!marioalexis wrote: ↑Wed Dec 29, 2021 10:57 pm If you want test this @Roy_043 : https://github.com/FreeCAD/FreeCAD/pull/5307
Re: [ Fixed by marioalexis ] Draft Workingplane: projectPoint issue
PR has been merged. Thanks again marioalexis!
https://github.com/FreeCAD/FreeCAD/pull/5307
https://github.com/FreeCAD/FreeCAD/pull/5307
- thomas-neemann
- Veteran
- Posts: 11801
- Joined: Wed Jan 22, 2020 6:03 pm
- Location: Osnabrück DE 🇩🇪
- Contact:
Re: [ Fixed by marioalexis ] Draft Workingplane: projectPoint issue
Marvelous. thank you