[ Fixed ] 3 small issues with Draft Patterns

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

[ Fixed ] 3 small issues with Draft Patterns

Post by Roy_043 »

3 small issues with Draft Patterns:
  • The Pattern list has a random order.
  • The diagonal1 and diagonal2 pattern seem identical.
  • In the source code there are 2 additional patterns that do not appear in the list: hatch45L and hatch45R. See Artwork_Draft.

Code: Select all

OS: Windows 8.1 (6.3)
Word size of FreeCAD: 64-bit
Version: 0.20.25220 (Git)
Build type: Release
Branch: master
Hash: 46282db7c8c65d1205a4cd03499d4beadb1573c6
Python version: 3.8.10
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.5.2
Locale: Dutch/Netherlands (nl_NL)
Last edited by Roy_043 on Fri Sep 24, 2021 4:33 pm, edited 1 time in total.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: 3 small issues with Draft Patterns

Post by Roy_043 »

I have meanwhile found out why hatch45L and hatch45R do not appear in the list. They are derived from the simple.svg pattern and still used that name as their id:

Code: Select all

<pattern height=".1" width=".1" y="0" x="0" patternUnits="userSpaceOnUse" id="simple">
If this is fixed then maybe simple.svg should be deleted?

EDIT: Deleting simple.svg is tricky. Patterns are not save with the document. So users who have applied this pattern will still need the file.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: 3 small issues with Draft Patterns

Post by Roy_043 »

Roy_043 wrote: Wed Aug 11, 2021 8:43 am The diagonal1 and diagonal2 pattern seem identical.
This is probably due to the hatch resolution. This value is currently hard-coded.

The other 2 issues should be fixed with:
https://github.com/FreeCAD/FreeCAD/pull/5060
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: [ Fixed ] 3 small issues with Draft Patterns

Post by Roy_043 »

Merged.
Post Reply