Reinforcement WB

Show off your FreeCAD projects here!
alex_V
Posts: 17
Joined: Wed Aug 08, 2018 5:25 pm

Reinforcement WB

Postby alex_V » Thu Aug 30, 2018 8:33 pm

Hi guys I've been working with the rebar addon and I'm trying to improve the way the objects are created. I created a tool for Wire Reinforcement Columns.
As you can see you only need to select the type of reinforcement you want,the faces for rebar and stirrup ( It also supports triangular stirrups) and edit, if you want to, the spacing, rebar diameter, rebar length, stirrup diameter,etc. So in 3 clicks you will have a reinforcement (with overlap) in your structure instead of having to create each rebar and stirrup.

I just need a little help, The Arch.makeRebar command doesn't work when the structure have an angle, maybe an error with the "Map a sketch to a face" command??
Attachments
Captura de pantalla de 2018-08-30 15-08-16.png
Captura de pantalla de 2018-08-30 15-08-16.png (260.91 KiB) Viewed 2010 times
Captura de pantalla de 2018-08-30 15-08-42.png
Captura de pantalla de 2018-08-30 15-08-42.png (266.07 KiB) Viewed 2010 times
Captura de pantalla de 2018-08-30 15-08-53.png
Captura de pantalla de 2018-08-30 15-08-53.png (242.94 KiB) Viewed 2010 times
Captura de pantalla de 2018-08-30 15-09-46.png
Captura de pantalla de 2018-08-30 15-09-46.png (252.88 KiB) Viewed 2010 times
Captura de pantalla de 2018-08-30 15-09-53.png
Captura de pantalla de 2018-08-30 15-09-53.png (291.16 KiB) Viewed 2010 times
User avatar
amrit3701
Posts: 241
Joined: Mon Jun 13, 2016 5:37 pm

Re: Reinforcement WB

Postby amrit3701 » Sun Sep 02, 2018 3:10 pm

alex_V wrote:
Thu Aug 30, 2018 8:33 pm
Hi guys I've been working with the rebar addon and I'm trying to improve the way the objects are created. I created a tool for Wire Reinforcement Columns.
As you can see you only need to select the type of reinforcement you want,the faces for rebar and stirrup ( It also supports triangular stirrups) and edit, if you want to, the spacing, rebar diameter, rebar length, stirrup diameter,etc. So in 3 clicks you will have a reinforcement (with overlap) in your structure instead of having to create each rebar and stirrup.

I just need a little help, The Arch.makeRebar command doesn't work when the structure have an angle, maybe an error with the "Map a sketch to a face" command??
Hi @alex_V,

I also saw the same error (see below attached image). On debugging, I found that the error is in execute function of ArchRebar._Rebar class. I think we are not passing a correct value of rot (https://github.com/FreeCAD/FreeCAD/blob ... ar.py#L378) to CalculatePlacement function.

@Yorik what you think?

I created below rebar by selected highlighted face.
error.png
error.png (213.76 KiB) Viewed 1850 times

Thanks,
alex_V
Posts: 17
Joined: Wed Aug 08, 2018 5:25 pm

Re: Reinforcement WB

Postby alex_V » Mon Sep 03, 2018 2:11 pm

Thanks @amrit3701,

Sometimes the sketch is in the right position but the solid is not. I think you are right about the CalculatePlacement function.
Attachments
Captura de pantalla de 2018-09-03 09-02-20.png
Captura de pantalla de 2018-09-03 09-02-20.png (284.84 KiB) Viewed 1773 times
Captura de pantalla de 2018-09-03 09-02-29.png
Captura de pantalla de 2018-09-03 09-02-29.png (324.12 KiB) Viewed 1773 times
User avatar
yorik
Site Admin
Posts: 11642
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Reinforcement WB

Postby yorik » Mon Sep 03, 2018 2:36 pm

amrit3701 wrote:
Sun Sep 02, 2018 3:10 pm
I also saw the same error (see below attached image). On debugging, I found that the error is in execute function of ArchRebar._Rebar class. I think we are not passing a correct value of rot (https://github.com/FreeCAD/FreeCAD/blob ... ar.py#L378) to CalculatePlacement function.
@Yorik what you think?
Probably.. it would require some debugging. But it seems to me the problem might be at https://github.com/FreeCAD/FreeCAD/blob ... ar.py#L371 it takes the rotation of the host Arch Structure, but the sketch itself might have a rotation too, maybe they need to be added.
User avatar
amrit3701
Posts: 241
Joined: Mon Jun 13, 2016 5:37 pm

Re: Reinforcement WB

Postby amrit3701 » Tue Sep 04, 2018 4:51 pm

alex_V wrote:
yorik wrote:
Mon Sep 03, 2018 2:36 pm
Probably.. it would require some debugging. But it seems to me the problem might be at https://github.com/FreeCAD/FreeCAD/blob ... ar.py#L371 it takes the rotation of the host Arch Structure, but the sketch itself might have a rotation too, maybe they need to be added.
Thanks, Yorik for the hint. :) Here is the PR: https://github.com/FreeCAD/FreeCAD/pull/1647
alex_V
Posts: 17
Joined: Wed Aug 08, 2018 5:25 pm

Re: Reinforcement WB

Postby alex_V » Tue Sep 04, 2018 6:09 pm

amrit3701 wrote:
Tue Sep 04, 2018 4:51 pm
alex_V wrote:
yorik wrote:
Mon Sep 03, 2018 2:36 pm
Thanks, Yorik for the hint. :) Here is the PR: https://github.com/FreeCAD/FreeCAD/pull/1647
Great job @amrit3701. Now the sketch and the rebar (as solid) have the same angle. The only problem that I see now is the way the points of the rebar (sketch) are created. They are created far from the structure.
Thanks a lot for taking your time in this fix!!
Attachments
Captura de pantalla de 2018-09-04 13-02-55.png
Captura de pantalla de 2018-09-04 13-02-55.png (367.88 KiB) Viewed 1652 times
Captura de pantalla de 2018-09-04 13-03-01.png
Captura de pantalla de 2018-09-04 13-03-01.png (388.29 KiB) Viewed 1652 times
Captura de pantalla de 2018-09-04 13-03-14.png
Captura de pantalla de 2018-09-04 13-03-14.png (328.61 KiB) Viewed 1652 times
User avatar
ebrahim raeyat
Posts: 177
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: Reinforcement WB

Postby ebrahim raeyat » Mon Sep 10, 2018 8:21 am

Hello. I am civil engineer and develop some minor software in my work. here is my blog:
http://ebrahimraeyat.blog.ir/post/civilTools_final

Image

recently I decide to start a framework project for civil engineer include some software:
1- first a pre/post processore graphical tools for opensees like this: http://gidopensees.rclab.civil.auth.gr/
it is opensource written in visual basic and has GPL3 licence. It is very perfect.
opensees navigatore:
Image
https://www.nextfem.it
Image

2- a desing engine for concrete and steel structure like etabs: https://www.csiamerica.com/products/etabs
3- a software that draw plane of concrete and steel sturcture like these software in my country (IRAN):
steel: http://www.rayansazeh.com/
concrete: http://www.saze90.com/about/drawing/beam, http://www.mohaseb2000.ir/,
http://www.farasaeg.ir/indexEN.htm

I want to write these software with python in freecad, I also use https://github.com/zhuminjie/OpenSeesPyDoc

I decide to use BIM for workflow. It is big idea and i want to start from number 3 and first for concrete structure.
please help me for this task ;)
User avatar
Joel_graff
Posts: 1619
Joined: Fri Apr 28, 2017 4:23 pm
Contact:

Re: Reinforcement WB

Postby Joel_graff » Mon Sep 17, 2018 11:56 pm

alex_V wrote:
Tue Sep 04, 2018 6:09 pm
ping
I think you're trying to solve a problem that was bugging me, too. I managed to get what I wanted to work.. sort of. The issue you cite with the rebar outside the structure, I managed to solve, but I had to write my own rebar generation code to do it as it differed pretty significantly from amrit's approach.

https://forum.freecadweb.org/viewtopic. ... 0&start=10
FreeCAD Trails workbench for transportation engineering: https://www.github.com/joelgraff/freecad.trails

pivy_trackers 2D coin3D library: https://www.github.com/joelgraff/pivy_trackers