Hi @alex_V,alex_V wrote: ↑Thu Aug 30, 2018 8:33 pmHi guys I've been working with the rebar addon and I'm trying to improve the way the objects are created. I created a tool for Wire Reinforcement Columns.
As you can see you only need to select the type of reinforcement you want,the faces for rebar and stirrup ( It also supports triangular stirrups) and edit, if you want to, the spacing, rebar diameter, rebar length, stirrup diameter,etc. So in 3 clicks you will have a reinforcement (with overlap) in your structure instead of having to create each rebar and stirrup.
I just need a little help, The Arch.makeRebar command doesn't work when the structure have an angle, maybe an error with the "Map a sketch to a face" command??
Probably.. it would require some debugging. But it seems to me the problem might be at https://github.com/FreeCAD/FreeCAD/blob ... ar.py#L371 it takes the rotation of the host Arch Structure, but the sketch itself might have a rotation too, maybe they need to be added.amrit3701 wrote: ↑Sun Sep 02, 2018 3:10 pmI also saw the same error (see below attached image). On debugging, I found that the error is in execute function of ArchRebar._Rebar class. I think we are not passing a correct value of rot (https://github.com/FreeCAD/FreeCAD/blob ... ar.py#L378) to CalculatePlacement function.
@Yorik what you think?
Thanks, Yorik for the hint. Here is the PR: https://github.com/FreeCAD/FreeCAD/pull/1647yorik wrote: ↑Mon Sep 03, 2018 2:36 pmProbably.. it would require some debugging. But it seems to me the problem might be at https://github.com/FreeCAD/FreeCAD/blob ... ar.py#L371 it takes the rotation of the host Arch Structure, but the sketch itself might have a rotation too, maybe they need to be added.
Great job @amrit3701. Now the sketch and the rebar (as solid) have the same angle. The only problem that I see now is the way the points of the rebar (sketch) are created. They are created far from the structure.
I think you're trying to solve a problem that was bugging me, too. I managed to get what I wanted to work.. sort of. The issue you cite with the rebar outside the structure, I managed to solve, but I had to write my own rebar generation code to do it as it differed pretty significantly from amrit's approach.