PR #1469 Qt5 compatible NaviCube

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
nyholku
Posts: 143
Joined: Wed Dec 28, 2016 4:18 pm

PR #1469 Qt5 compatible NaviCube

Postby nyholku » Thu May 24, 2018 7:00 pm

Hi,

I finally rebased my branch and created a pull request.

wbr Kusti
pablogil
Posts: 656
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: PR #1469 Qt5 compatible NaviCube

Postby pablogil » Fri May 25, 2018 7:40 am

I can't wait to see it merged and try it out
:D
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
dulouie
Posts: 50
Joined: Tue Oct 03, 2017 4:14 pm

Re: PR #1469 Qt5 compatible NaviCube

Postby dulouie » Fri May 25, 2018 8:45 am

Yes, this nice cube is waiting in the queue for too long.
wmayer
Site Admin
Posts: 12758
Joined: Thu Feb 19, 2009 10:32 am

Re: PR #1469 Qt5 compatible NaviCube

Postby wmayer » Sat May 26, 2018 1:53 pm

Your Qt5 port of NaviCube didn't compile on any platform and due to exclusive use of QOpenGLTexture of course didn't work for Qt4 either. Thus, I switched back to your original implementation based on GLuint and did the Qt5 port myself.

Also, I added the option to switch it off and fixed several issues like slow rendering due to creation of an image which is never used, several memory leaks and possible crashes if the GL context gets destroyed.
nyholku
Posts: 143
Joined: Wed Dec 28, 2016 4:18 pm

Re: PR #1469 Qt5 compatible NaviCube

Postby nyholku » Sat May 26, 2018 5:14 pm

Brilliant! Thank you very much.
User avatar
easyw-fc
Posts: 1636
Joined: Thu Jul 09, 2015 9:34 am

Re: PR #1469 Qt5 compatible NaviCube

Postby easyw-fc » Tue May 29, 2018 7:58 am

nyholku wrote:
Sat May 26, 2018 5:14 pm
Brilliant! Thank you very much.
would it be possible to trig 'Zoom to fit' when clicking on a view already selected?
i.e. I click on 'Top' and the activeView is already the Top View, then 'Zoom to fit' is triggered.
User avatar
NormandC
Posts: 15531
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: PR #1469 Qt5 compatible NaviCube

Postby NormandC » Tue May 29, 2018 5:00 pm

wmayer wrote:
Sat May 26, 2018 1:53 pm
Thus, I switched back to your original implementation based on GLuint and did the Qt5 port myself.
Do you mean that it works on Qt4?

EDIT: sorry, should have checked commits before asking!

git commit ddf881a1

Thanks!!! :D

Time to fire up the freecad-daily version! :)
triplus
Posts: 6940
Joined: Mon Dec 12, 2011 4:45 pm

Re: PR #1469 Qt5 compatible NaviCube

Postby triplus » Sat Jun 02, 2018 11:42 am

Congratulations!