FEM: different fixes

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
Post Reply
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

FEM: different fixes

Post by PrzemoF »

The following changes since commit f068e723eaf9ab9588a0196efbd25c0dbdd636c9:

Remember last tab selected in PropertyView (2015-04-15 09:12:30 +1200)

are available in the git repository at:

https://github.com/PrzemoF/FreeCAD_sf_master.git fem_v6

for you to fetch changes up to ea5c01f7e14e5d5460bba2ba390f029a75bb6d7f:

FEM: Fix typo in fem_console_message name (2015-04-15 15:39:23 +0100)

----------------------------------------------------------------
Przemo Firszt (14):
FEM: Sort materials within each category
FEM: Change way of converting ccx output to unicode
FEM: Catch ccx errors and print to FEM console in red
FEM: Use default True value for material dirs
FEM: Use built-in None material if there was no previous material
FEM: Rename chooseMat to choose_material
FEM: Group all helper functions together
FEM: Fix typos
FEM: Make sure cursor gets restored if write_calculix_input_file fails
FEM: Disable "open editor" and "run ccx" buttons.
FEM: No need to check length, empty list evaluates to False
FEM: Fix typo. Rename MathObject to MaterialObject
FEM: Fix rare crash related to the date of compilation of ccx
FEM: Fix typo in fem_console_message name

src/Mod/Fem/MechanicalAnalysis.py | 129 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------
src/Mod/Fem/MechanicalAnalysis.ui | 6 +++++
src/Mod/Fem/MechanicalMaterial.py | 81 +++++++++++++++++++++++++++++++++++++-------------------------------
3 files changed, 125 insertions(+), 91 deletions(-)
User avatar
shoogen
Veteran
Posts: 2823
Joined: Thu Dec 01, 2011 5:24 pm

Re: FEM: different fixes

Post by shoogen »

The encode and decode methods have the ability to ignore errors or to replace offending characters.
https://docs.python.org/2/library/codec ... se-classes
IMHO for log messages errors='replace' makes more sense then the default errors='strict' combined with handling the exception.
Because in your current solution the whole message gets lost (and replaced).
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: FEM: different fixes

Post by bernd »

just tested, looks good to me on debian jessie.

Saw in CalculiX manual the maximum lenght for material name is 80 charakters http://web.mit.edu/calculix_v2.7/Calcul ... de216.html

Should we check this too?
wmayer
Founder
Posts: 20319
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: FEM: different fixes

Post by wmayer »

Merged.
Post Reply