TechDraw to Master

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
User avatar
sgrogan
Posts: 6166
Joined: Wed Oct 22, 2014 5:02 pm

Re: TechDraw to Master

Postby sgrogan » Mon Jul 11, 2016 10:19 pm

yorik wrote:+1. I still have problems compiling the TechDraw branch, but let's attack that in master... Just be prepared that if others also fail to compile, or the PPA fails, etc, you will have to deal with the angry mob ;)
The PPA builds for Trusty, Wily, and Xenial.
It fails for Yakkety

Code: Select all

[ 34%] Building CXX object src/Gui/CMakeFiles/FreeCADGui.dir/ExpressionBinding.cpp.o
cd "/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui" && /usr/bin/x86_64-linux-gnu-g++   -DCMAKE_BUILD_TYPE=\"None\" -DFreeCADGui_EXPORTS -DHAVE_CONFIG_H -DHAVE_PYSIDE -DHAVE_SHIBOKEN -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_SVG_LIB -DQT_UITOOLS_LIB -DQT_WEBKIT_LIB -DQT_XML_LIB -DSPNAV_FOUND -D_OCC64 -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu" -isystem /usr/include/qt4 -isystem /usr/include/qt4/QtOpenGL -isystem /usr/include/qt4/QtSvg -isystem /usr/include/qt4/QtUiTools -isystem /usr/include/qt4/QtWebKit -isystem /usr/include/qt4/QtGui -isystem /usr/include/qt4/QtXml -isystem /usr/include/qt4/QtNetwork -isystem /usr/include/qt4/QtCore -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src/Gui" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src/Gui/Quarter" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src/Gui/.." -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/.." -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/Language" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/propertyeditor" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/TaskView" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/Quarter" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/DAGView" -I/usr/include/python2.7 -I/usr/include/shiboken -I/usr/include/PySide -I/usr/include/PySide/QtCore -I/usr/include/PySide/QtGui  -Wall -Wno-deprecated -Wno-write-strings -Wall -DHAVE_SWIG=1 -fpermissive -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++11 -D_OCC64 -fPIC   -o CMakeFiles/FreeCADGui.dir/ExpressionBinding.cpp.o -c "/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src/Gui/ExpressionBinding.cpp"
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o: In function `MPI::Op::Init(void (*)(void const*, void*, int, MPI::Datatype const&), bool)':
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/op_inln.h:122: undefined reference to `ompi_mpi_cxx_op_intercept'
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o: In function `MPI::Intracomm::Intracomm(ompi_communicator_t*)':
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm_inln.h:23: undefined reference to `MPI::Comm::Comm()'
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o: In function `MPI::Intracomm::Intracomm()':
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: undefined reference to `MPI::Comm::Comm()'
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: undefined reference to `MPI::Comm::Comm()'
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: undefined reference to `MPI::Comm::Comm()'
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: undefined reference to `MPI::Comm::Comm()'
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o:/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: more undefined references to `MPI::Comm::Comm()' follow
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o:(.data.rel.ro._ZTVN3MPI8DatatypeE[_ZTVN3MPI8DatatypeE]+0x78): undefined reference to `MPI::Datatype::Free()'
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o:(.data.rel.ro._ZTVN3MPI3WinE[_ZTVN3MPI3WinE]+0x48): undefined reference to `MPI::Win::Free()'
collect2: error: ld returned 1 exit status
src/3rdParty/salomesmesh/CMakeFiles/SMESH.dir/build.make:1248: recipe for target 'lib/libSMESH.so' failed
make[3]: *** [lib/libSMESH.so] Error 1
make[3]: Leaving directory '/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:577: recipe for target 'src/3rdParty/salomesmesh/CMakeFiles/SMESH.dir/all' failed
make[2]: *** [src/3rdParty/salomesmesh/CMakeFiles/SMESH.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
I think the libs are close to Debian testing. Maybe there is a clue somewhere. VTK6 is v6.3 on Yakkety, <=6.2.x on the other releases. v6.1.x is a problem on Jessie?
"fight the good fight"
user1234
Posts: 277
Joined: Mon Jul 11, 2016 5:08 pm

Re: TechDraw to Master

Postby user1234 » Mon Jul 11, 2016 11:07 pm

sgrogan wrote:6.1.x is a problem on Jessie?
for me no
(0 errors and 0 warnings)

Code: Select all

OS: Debian GNU/Linux 8.5 (jessie)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.7957 (Git)
Build type: Unknown
Branch: master
Hash: 2ac560e7b027590e8d6b534b84020d4c1624ece5
Python version: 2.7.9
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 6.8.0.oce-0.17
and vtk6.1.0
User avatar
yorik
Site Admin
Posts: 12064
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: TechDraw to Master

Postby yorik » Tue Jul 12, 2016 12:07 am

sgrogan wrote: I think the libs are close to Debian testing. Maybe there is a clue somewhere. VTK6 is v6.3 on Yakkety, <=6.2.x on the other releases. v6.1.x is a problem on Jessie?
Yes my error is exactly the same as ubuntu yak. And indeed I have vtk6.3 here. But just before the merge, the master code still compiled fine, I don't understand!

Anyone else using vtk6.3?
blacey
Posts: 370
Joined: Tue Dec 08, 2015 11:28 pm

Re: TechDraw to Master

Postby blacey » Tue Jul 12, 2016 12:11 am

yorik wrote:[Yes my error is exactly the same as ubuntu yak. And indeed I have vtk6.3 here. But just before the merge, the master code still compiled fine, I don't understand!
Not VTK 6.3 but builds fine with VTK 7.0 - just additional FYI for root cause determination.
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: TechDraw to Master

Postby NormandC » Tue Jul 12, 2016 2:42 am

I want to thank Luke for starting this effort, and Ian and wandererfan for picking it up and bringing it to a state where it could be merged.

This is a huge step for FreeCAD. With all the other stuff brewing, the 0.17 release is going to be the best one yet. :)

Kuddos to you guys!!!
User avatar
bernd
Posts: 10957
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: TechDraw to Master

Postby bernd » Tue Jul 12, 2016 4:36 am

On Debian Jessie, I use self compiled VTK 7.0.0
User avatar
wandererfan
Posts: 4078
Joined: Tue Nov 06, 2012 5:42 pm

Re: TechDraw to Master

Postby wandererfan » Tue Jul 12, 2016 12:27 pm

yorik wrote:Anyone else using vtk6.3?
I use vtk6.3.0 compiled from source, but I'm on 12.04 Precise. I had trouble with vtk7.0.0 compiled from source.
User avatar
wandererfan
Posts: 4078
Joined: Tue Nov 06, 2012 5:42 pm

Re: TechDraw to Master

Postby wandererfan » Tue Jul 12, 2016 1:24 pm

sgrogan wrote:The PPA builds for Trusty, Wily, and Xenial. It fails for Yakkety
I have no answers yet, but maybe some clues. "MPI::Common::Common()" and friends not found happens in apps other than FC. It seems there are different bindings to the library and you need to use the right ones. On my system I have 3 mpi libs:

Code: Select all

/usr/lib/libmpi_cxx
/usr/lib/libmpi
/usr/lib/libmpi++
My CMake/make game is weak, but here are some possible clues:

http://stackoverflow.com/questions/1754 ... ompilation
http://www.paraview.org/pipermail/parav ... 15098.html
http://comments.gmane.org/gmane.comp.cl ... user/19509
http://help.eclipse.org/luna/topic/org. ... oting.html

Hope this is helpful.

wf
User avatar
yorik
Site Admin
Posts: 12064
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: TechDraw to Master

Postby yorik » Tue Jul 12, 2016 2:18 pm

ok got it! I ran "make VERBOSE=1" up to the moment it crashes, then I re-run the latest make command adding "-lmpi_cxx" and it works.
Not sure where to add this in Cmake... and if there should be MPI-related stuff in it at all ( like in http://stackoverflow.com/questions/3555 ... re-linking ). In any case this is for another topic...
jmaustpc
Posts: 10368
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: TechDraw to Master

Postby jmaustpc » Tue Jul 12, 2016 4:01 pm

this is great news, thanks for all the work.