TechDraw to Master

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
flokart
Posts: 21
Joined: Sun Apr 10, 2016 12:15 pm

Re: TechDraw to Master

Postby flokart » Tue Jul 12, 2016 5:11 pm

Thanks a lot for this nice workbench...wicked sick.
Is this the right place to report crashes while using techdraw ? Or should i just wait ?
How can i compare known misbehaviour with my unexpected results is there already a bug list for techdraw ?

Thanks
User avatar
sgrogan
Posts: 6166
Joined: Wed Oct 22, 2014 5:02 pm

Re: TechDraw to Master

Postby sgrogan » Tue Jul 12, 2016 5:25 pm

flokart wrote:Is this the right place to report crashes while using techdraw ? Or should i just wait ?
Open a new topic in the help forum so we can triage the bugs. Then we can ask wondererfan if he wants the bugs reported on the TechDraw issue tracker or mantis.
flokart wrote:How can i compare known misbehaviour with my unexpected results is there already a bug list for techdraw ?
https://github.com/WandererFan/FreeCAD-TechDraw/issues
"fight the good fight"
User avatar
f3nix
Posts: 339
Joined: Sat May 30, 2015 11:58 am

Re: TechDraw to Master

Postby f3nix » Tue Jul 12, 2016 8:38 pm

sgrogan wrote:
yorik wrote:+1. I still have problems compiling the TechDraw branch, but let's attack that in master... Just be prepared that if others also fail to compile, or the PPA fails, etc, you will have to deal with the angry mob ;)
The PPA builds for Trusty, Wily, and Xenial.
It fails for Yakkety

Code: Select all

[ 34%] Building CXX object src/Gui/CMakeFiles/FreeCADGui.dir/ExpressionBinding.cpp.o
cd "/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui" && /usr/bin/x86_64-linux-gnu-g++   -DCMAKE_BUILD_TYPE=\"None\" -DFreeCADGui_EXPORTS -DHAVE_CONFIG_H -DHAVE_PYSIDE -DHAVE_SHIBOKEN -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_SVG_LIB -DQT_UITOOLS_LIB -DQT_WEBKIT_LIB -DQT_XML_LIB -DSPNAV_FOUND -D_OCC64 -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu" -isystem /usr/include/qt4 -isystem /usr/include/qt4/QtOpenGL -isystem /usr/include/qt4/QtSvg -isystem /usr/include/qt4/QtUiTools -isystem /usr/include/qt4/QtWebKit -isystem /usr/include/qt4/QtGui -isystem /usr/include/qt4/QtXml -isystem /usr/include/qt4/QtNetwork -isystem /usr/include/qt4/QtCore -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src/Gui" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src/Gui/Quarter" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src/Gui/.." -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/.." -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/Language" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/propertyeditor" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/TaskView" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/Quarter" -I"/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu/src/Gui/DAGView" -I/usr/include/python2.7 -I/usr/include/shiboken -I/usr/include/PySide -I/usr/include/PySide/QtCore -I/usr/include/PySide/QtGui  -Wall -Wno-deprecated -Wno-write-strings -Wall -DHAVE_SWIG=1 -fpermissive -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++11 -D_OCC64 -fPIC   -o CMakeFiles/FreeCADGui.dir/ExpressionBinding.cpp.o -c "/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/src/Gui/ExpressionBinding.cpp"
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o: In function `MPI::Op::Init(void (*)(void const*, void*, int, MPI::Datatype const&), bool)':
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/op_inln.h:122: undefined reference to `ompi_mpi_cxx_op_intercept'
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o: In function `MPI::Intracomm::Intracomm(ompi_communicator_t*)':
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm_inln.h:23: undefined reference to `MPI::Comm::Comm()'
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o: In function `MPI::Intracomm::Intracomm()':
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: undefined reference to `MPI::Comm::Comm()'
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: undefined reference to `MPI::Comm::Comm()'
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: undefined reference to `MPI::Comm::Comm()'
/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: undefined reference to `MPI::Comm::Comm()'
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o:/usr/lib/openmpi/include/openmpi/ompi/mpi/cxx/intracomm.h:25: more undefined references to `MPI::Comm::Comm()' follow
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o:(.data.rel.ro._ZTVN3MPI8DatatypeE[_ZTVN3MPI8DatatypeE]+0x78): undefined reference to `MPI::Datatype::Free()'
CMakeFiles/SMESH.dir/src/SMESH/DriverMED_Family.cpp.o:(.data.rel.ro._ZTVN3MPI3WinE[_ZTVN3MPI3WinE]+0x48): undefined reference to `MPI::Win::Free()'
collect2: error: ld returned 1 exit status
src/3rdParty/salomesmesh/CMakeFiles/SMESH.dir/build.make:1248: recipe for target 'lib/libSMESH.so' failed
make[3]: *** [lib/libSMESH.so] Error 1
make[3]: Leaving directory '/«BUILDDIR»/freecad-daily-0.17~alpha1+git201607112039~ubuntu16.10.1/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:577: recipe for target 'src/3rdParty/salomesmesh/CMakeFiles/SMESH.dir/all' failed
make[2]: *** [src/3rdParty/salomesmesh/CMakeFiles/SMESH.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
I think the libs are close to Debian testing. Maybe there is a clue somewhere. VTK6 is v6.3 on Yakkety, <=6.2.x on the other releases. v6.1.x is a problem on Jessie?
Same here on Debian SID with VTK 6.3.

The problem seems to be this line CMakeLists.txt#L93 from this commit a46fd856d4bc51397992f10392c837d5c8abdf3c

Commenting it out again seems to fix the build failure. I have not checked it any further yet.

HTH.

Cheers,
Mateusz

OS: Debian GNU/Linux unstable (sid)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.7957 (Git)
Build type: Debug
Branch: master
Hash: 2ac560e7b027590e8d6b534b84020d4c1624ece5
Python version: 2.7.12
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 6.8.0.oce-0.17
User avatar
sgrogan
Posts: 6166
Joined: Wed Oct 22, 2014 5:02 pm

Re: TechDraw to Master

Postby sgrogan » Tue Jul 12, 2016 9:07 pm

f3nix wrote:Commenting it out again seems to fix the build failure. I have not checked it any further yet.
Thanks Mateusz.
Your change doesn't hurt locally compiled Trusty using the same libs as the PPA.
OS: Ubuntu 14.04.4 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.7957 (Git)
Build type: Unknown
Branch: mpicomm
Hash: 2ac560e7b027590e8d6b534b84020d4c1624ece5
Python version: 2.7.6
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 6.8.0.oce-0.17
"fight the good fight"
wmayer
Site Admin
Posts: 16649
Joined: Thu Feb 19, 2009 10:32 am

Re: TechDraw to Master

Postby wmayer » Wed Jul 13, 2016 7:17 am

The problem seems to be this line CMakeLists.txt#L93 from this commit a46fd856d4bc51397992f10392c837d5c8abdf3c
This is definitely not the problem. These linker flags only raise possible linking errors already at compile time, otherwise you will get them at runtime.
User avatar
sgrogan
Posts: 6166
Joined: Wed Oct 22, 2014 5:02 pm

Re: TechDraw to Master

Postby sgrogan » Wed Jul 13, 2016 3:33 pm

wmayer wrote:This is definitely not the problem. These linker flags only raise possible linking errors already at compile time, otherwise you will get them at runtime.
I see now, but this does explain why the error just popped up though. The line has been commented out since commit 8941868
"fight the good fight"