PR 270: TechDraw Fixes, Centerlines and EdgeWalkerPy

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
Post Reply
User avatar
wandererfan
Veteran
Posts: 6320
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

PR 270: TechDraw Fixes, Centerlines and EdgeWalkerPy

Post by wandererfan »

Please merge #270. It includes a bunch of minor fixes and Python access to EdgeWalker for finding faces in collections of edges.

Thanks,
wf
user1234
Veteran
Posts: 3506
Joined: Mon Jul 11, 2016 5:08 pm

Re: PR 270: TechDraw Fixes, Centerlines and EdgeWalkerPy

Post by user1234 »

Hello!

The fixes are great. Techdraw is much faster than before! But the arrows are false. I draw position and the direction of the arrow in the picture.
screenshot.png
screenshot.png (72.84 KiB) Viewed 926 times
(please note the side of the chamfer and the fillet).

Also some parts have problems with the first view. So then the section view also fails.

Tested on:

Code: Select all

OS: Debian GNU/Linux 8.5 (jessie)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.8367 (Git)
Build type: Unknown
Branch: master
Hash: cc167bd2c84d1fd0cd3eda57fd37dcf049ba8182
Python version: 2.7.9
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 6.8.0.oce-0.17
VTK 7.0.0
Thanks for the lot of work! It is a important work, because technical drawings are the basic for the step from virtual parts to real parts.

I hope you understand me, because english is not my native language.

Greetings, user1234
Attachments
testfile_right_settings.fcstd
(341.32 KiB) Downloaded 13 times
User avatar
wandererfan
Veteran
Posts: 6320
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: PR 270: TechDraw Fixes, Centerlines and EdgeWalkerPy

Post by wandererfan »

user1234 wrote:Techdraw is much faster than before!
I've been struggling with performance all week. Looks like big problems deep inside OCC. Glad it's working well for you.
user1234 wrote:But the arrows are false. I draw position and the direction of the arrow in the picture.
:( I thought I had those sorted out. Back to the drawing board.
user1234 wrote:Also some parts have problems with the first view. So then the section view also fails.
Did you get any messages in your Report View? Some of the ones I've seen:
. xDirection cannot equal +/- viewDirection. Using (0,1,0) (or (1,0,0)...)
. Bnd_Box is null
. Section origin is not within part, using center of bounding box.
Any of these will turn on the red error indicator.

Again, thanks for testing, feedback and test files. Very big help indeed!

wf
Post Reply