[Merged]Regular polygons

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
User avatar
DevJohan
Posts: 41
Joined: Sun Jul 13, 2014 2:36 pm
Location: Stockholm, Sweden

Re: [Merged]Regular polygons

Postby DevJohan » Tue Jul 29, 2014 2:28 pm

I think I've fixed the problems now. Did a clean build and It seems to work. I have not added the Regular polygon to the ProfileLib Menu because that would require some sort of dialog to choose the number of sides. Perhaps all the Regular polygon buttons should only be in the ProfileLib menu, but then It would be preferable if they were interactive once chosen unlike the hexagon script.
User avatar
saso
Posts: 1310
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: [Merged]Regular polygons

Postby saso » Tue Jul 29, 2014 3:22 pm

Just a side note... I have asked for possible usefulness of https://travis-ci.org/ for the FreeCAD project in another topic, at that time I was thinking about it more as a possible first step to have automated nightly builds, but at this site http://code.tutsplus.com/tutorials/trav ... -net-34771 there is also a description of it for automating and helping when merging to the master
jmaustpc
Posts: 9566
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: [Merged]Regular polygons

Postby jmaustpc » Tue Jul 29, 2014 3:30 pm

DevJohan wrote:I have not added the Regular polygon to the ProfileLib Menu because that would require some sort of dialog to choose the number of sides. Perhaps all the Regular polygon buttons should only be in the ProfileLib menu, but then It would be preferable if they were interactive once chosen unlike the hexagon script.
Hi Johan
If you move these to the Profile menu then you will presumably want profile icons matching the profile style icon for the current Hexagon. You obviously did a good job of the last icons so can no doubt do it yourself, but if you would like me to I will make them for you if it saves you time. :)

Anyway if you want me to, just post a note and I will do them for you. :)

Jim
wmayer
Site Admin
Posts: 14782
Joined: Thu Feb 19, 2009 10:32 am

Re: [Merged]Regular polygons

Postby wmayer » Tue Jul 29, 2014 3:39 pm

Thanks again Johan for your great work. Everything works well and now it's also pretty fast.
jmaustpc
Posts: 9566
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: [Merged]Regular polygons

Postby jmaustpc » Tue Jul 29, 2014 3:55 pm

wmayer wrote:Thanks again Johan for your great work. Everything works well and now it's also pretty fast.
You right about that Werner!

Johan, this added functionality is great! :)
User avatar
DevJohan
Posts: 41
Joined: Sun Jul 13, 2014 2:36 pm
Location: Stockholm, Sweden

Re: [Merged]Regular polygons

Postby DevJohan » Tue Jul 29, 2014 4:51 pm

Thanks guys!

I don't think I will change anything more regarding this feature without more input. But if you want me to change anything just let me know and I'll do it :).