[Fixed] Segfaults when using "Make a thick solid" tool

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
wmayer
Founder
Posts: 20324
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Segfaults when using "Make a thick solid" tool

Post by wmayer »

2. The operation will fail, if not, make something that cannot be computed and
It doesn't matter if the thickness can be computed or not. E.g. you can create a standard PD box and select one of its faces. The thickness tool is able to succeed the operation but when clicking on Cancel the application crashes, too.
wmayer
Founder
Posts: 20324
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Segfaults when using "Make a thick solid" tool

Post by wmayer »

This fixes the crash: git commit ff0f8b0d8
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: Segfaults when using "Make a thick solid" tool

Post by realthunder »

wmayer wrote: Wed Sep 16, 2020 11:42 am This fixes the crash: git commit ff0f8b0d8
I also did a fix, but then found out that you've beat me to it.

I also fixed another minor problem and submitted a PR here. It happened when I test the file attached here. The property editor did a redundant recompute when closing a transaction that is opened by the part design task panel.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
wmayer
Founder
Posts: 20324
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Segfaults when using "Make a thick solid" tool

Post by wmayer »

I also fixed another minor problem and submitted a PR here. It happened when I test the file attached here.
I have observed this behaviour too and each time you switch from Tree/Property view to the Task view a recompute was performed. With the very small attached test project from Leo it took 2s in the debug mode. So, thanks for the quick fix.
leoheck
Veteran
Posts: 1225
Joined: Tue Mar 13, 2018 5:56 pm
Location: Coffee shop

Re: Segfaults when using "Make a thick solid" tool

Post by leoheck »

And thanks for all the fixes, you are great guys.
Post Reply