Drawing workbench active by default

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Drawing workbench active by default

Post by adrianinsaval »

this is where the draft test fails if drawing workbench isn't built: https://github.com/FreeCAD/FreeCAD/blob ... on.py#L543
User avatar
wandererfan
Veteran
Posts: 6265
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Drawing workbench active by default

Post by wandererfan »

wmayer wrote: Fri Jun 24, 2022 6:15 am ... there is still a link dependency: https://github.com/FreeCAD/FreeCAD/blob ... ts.txt#L39 However, this dependency can be simply removed without causing any linking errors.
git commit 175d2cf2dd
wmayer
Founder
Posts: 20241
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Drawing workbench active by default

Post by wmayer »

adrianinsaval wrote: Sat Jun 25, 2022 1:33 am this is where the draft test fails if drawing workbench isn't built: https://github.com/FreeCAD/FreeCAD/blob ... on.py#L543
git commit 02bc430fac13
wmayer
Founder
Posts: 20241
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Drawing workbench active by default

Post by wmayer »

Disable Drawing module: git commit d7313598aace
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Drawing workbench active by default

Post by yorik »

wmayer wrote: Sat Jun 25, 2022 4:08 pm adrianinsaval wrote: ↑25 Jun 2022, 03:33
this is where the draft test fails if drawing workbench isn't built: https://github.com/FreeCAD/FreeCAD/blob ... on.py#L543
git commit 02bc430fac13
We could switch this test to use the TechDraw WB... I'll do that today
*EDIT* Hm in fact all that functionality is rather obsolete now... Better remove it entirely.
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Drawing workbench active by default

Post by adrianinsaval »

@yorik

Code: Select all

======================================================================
ERROR: testSection (TestArch.ArchTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/freecad/Mod/Arch/TestArch.py", line 607, in testSection
    v = Arch.makeSectionView(s)
  File "/usr/lib/freecad/Mod/Arch/ArchSectionPlane.py", line 97, in makeSectionView
    page = FreeCAD.ActiveDocument.addObject("Drawing::FeaturePage","Page")
ModuleNotFoundError: {'sclassname': 'N4Base11PyExceptionE', 'sErrMsg': "No module named 'Drawing'", 'sfile': '', 'iline': 0, 'sfunction': '', 'swhat': "No module named 'Drawing'", 'btranslatable': False, 'breported': False}
I don't know how this one didn't come up before :oops:
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Drawing workbench active by default

Post by adrianinsaval »

should any of these changes be backported to 0.20 or do we keep drawing workbench for future point releases?
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Drawing workbench active by default

Post by yorik »

adrianinsaval wrote: Wed Jun 29, 2022 7:45 pm I don't know how this one didn't come up before :oops:
Fixed provisorily with git commit e916f8afbb (trying to decide if we still need an arch drawing view...)
adrianinsaval wrote: Wed Jun 29, 2022 8:33 pm should any of these changes be backported to 0.20 or do we keep drawing workbench for future point releases?
I don't think there is any advantage in backport this to 0.20... It's something for the future, not a bugfix.
Post Reply