Curves workbench

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
User avatar
Chris_G
Posts: 1567
Joined: Tue Dec 31, 2013 4:10 pm
Location: France
Contact:

Re: Curves workbench

Postby Chris_G » Tue Nov 17, 2020 6:06 pm

Indeed.
I just pushed a fix.
Thanks.
User avatar
GlouGlou
Posts: 2734
Joined: Sun Apr 05, 2015 9:02 am
Location: La Rochelle, France

Re: Curves workbench

Postby GlouGlou » Tue Nov 17, 2020 9:15 pm

Info tools seems give the legth of the circle instead the arc length.
Attachments
length.FCStd
(4.6 KiB) Downloaded 4 times
Capture.JPG
Capture.JPG (23.15 KiB) Viewed 476 times
User avatar
Chris_G
Posts: 1567
Joined: Tue Dec 31, 2013 4:10 pm
Location: France
Contact:

Re: Curves workbench

Postby Chris_G » Wed Nov 18, 2020 1:38 pm

GlouGlou wrote:
Tue Nov 17, 2020 9:15 pm
Info tools seems give the legth of the circle instead the arc length.
GeomInfo was first intended to display Geometry info.
But since I already added a couple of topolgy info in the text (tolerance, 2d curves), it make sense to also display edge length.
It now display : Edge Length (+ Geometry curve length if different )
Attachments
geominfo2.png
geominfo2.png (11.07 KiB) Viewed 424 times
neildarlow
Posts: 33
Joined: Mon Mar 17, 2014 1:29 pm

Re: Curves workbench

Postby neildarlow » Mon Nov 30, 2020 5:32 pm

Hi,

Please may I highlight two tooltip quirks?

1)
info.png
info.png (30.7 KiB) Viewed 323 times
I think the first word, displays, should be Display i.e. singular and first-letter as uppercase.

2)
blending.png
blending.png (26.47 KiB) Viewed 323 times
I think this should read: Blend surface between two curveOnSurface objects i.e. noun instead of verb, lowercase Surface and two instead of to.

These are trivial changes but beneficial.

Regards,
Neil
User avatar
Kunda1
Posts: 9185
Joined: Thu Jan 05, 2017 9:03 pm

Re: Curves workbench

Postby Kunda1 » Mon Nov 30, 2020 6:05 pm

neildarlow wrote:
Mon Nov 30, 2020 5:32 pm
These are trivial changes but beneficial.
Good catch. Submitted PR: https://github.com/tomate44/CurvesWB/pull/35
Alone you go faster. Together we go farther
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Chris_G
Posts: 1567
Joined: Tue Dec 31, 2013 4:10 pm
Location: France
Contact:

Re: Curves workbench

Postby Chris_G » Mon Nov 30, 2020 6:09 pm

Merged. Thanks.
User avatar
Kunda1
Posts: 9185
Joined: Thu Jan 05, 2017 9:03 pm

Re: Curves workbench

Postby Kunda1 » Fri Dec 04, 2020 4:02 pm

Chris_G wrote: :bell:
@Chris_G in the UI there is a mixed curves command but it uses combined_curves.svg. Is it possible to rename one of them?

Edit: source: https://github.com/luzpaz/CurvesWB/blob ... rve.py#L16

---------
There is a ./Curves/bezierCurve-2.py
This seems to be a dupe. Is that intentional? If it's a WIP, perhaps you can put it on a different branch so it doesn't pollute the main branch ?

---------
It may be useful to put some separators in between the Curves toolbar commands. In order to group them. Or perhaps split the toolbar in to several smaller ones so that users can have the option to manipulate/reposition the toolbars to match their workflow?
Alone you go faster. Together we go farther
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Posts: 9185
Joined: Thu Jan 05, 2017 9:03 pm

Re: Curves workbench

Postby Kunda1 » Fri Dec 04, 2020 9:14 pm

In addition to the above. I've also created a PR while creating documentation on the wiki for Curves WB
https://github.com/tomate44/CurvesWB/pull/37
Alone you go faster. Together we go farther
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Posts: 9185
Joined: Thu Jan 05, 2017 9:03 pm

Re: Curves workbench

Postby Kunda1 » Sat Dec 05, 2020 2:02 am

GlouGlou wrote: :bell:
@GlouGlou would you be open to continue creating documentation in the wiki in regards to Curves Workbench ?
Alone you go faster. Together we go farther
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
GlouGlou
Posts: 2734
Joined: Sun Apr 05, 2015 9:02 am
Location: La Rochelle, France

Re: Curves workbench

Postby GlouGlou » Sat Dec 05, 2020 3:29 pm

I will try. ;) Could you make the templates for the empty pages, please.