0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
Forum rules
and Helpful information
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help
Also, be nice to others! Read the FreeCAD code of conduct!
Also, be nice to others! Read the FreeCAD code of conduct!
0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
Moderators: Not sure where you would like to have this. Feel free to move it to another subforum.
I write to ask for user input regarding this feature. Something is telling me that is not working as expected, but I am not sure what I would like to have. Does this look like what is requested?
I write to ask for user input regarding this feature. Something is telling me that is not working as expected, but I am not sure what I would like to have. Does this look like what is requested?
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
Not sure what was "requested", but that would be a nice feature.
I have always made that sort of shape with three arcs connected using end-to-end tangency. This new method would be easier.
Gene
I have always made that sort of shape with three arcs connected using end-to-end tangency. This new method would be easier.
Gene
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
Hi abdullah
In my point of view it's exact the expected result when you filet two arcs. The result is similar as when you do this with just two lines. Great that you have implemented this.
What other result can you imagine, when you filet two arcs? What makes you worry about your current implementation?
Kind regards
Roger
In my point of view it's exact the expected result when you filet two arcs. The result is similar as when you do this with just two lines. Great that you have implemented this.
What other result can you imagine, when you filet two arcs? What makes you worry about your current implementation?
Kind regards
Roger
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
I am not sure exactly what is requested. I am not sure this is the way (tm). Curves are trickier than segments, as curvature keeps changing. It also admits a plurality of intersections. I am struggling to consistently get the same result. But it is good to see that what is shown is what is expected.
One initial problem I had was related to the fact that curvature keeps changing, so it is very relevant where you click the segments. I had also to restrict to curves that (if extended) intersect.
As of now, it does not work segment with arc of conic. It does not work with B-splines. Sometimes I am still getting a very wrong result. See:
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
ooh, I bet @joel_graff (who's working on the Transportation Engineering WB) would dig this thread
Joel_graff wrote:
Last edited by Kunda1 on Tue Oct 16, 2018 5:43 pm, edited 1 time in total.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
Does it work as well with just clicking the corner?
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
- Joel_graff
- Veteran
- Posts: 1949
- Joined: Fri Apr 28, 2017 4:23 pm
- Contact:
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
That's really awesome. Nice that it's integrated into the existing tool, too - eliminates the need for geometry checking.
I wrote a monstrous amount of python code to achieve this same effect, but my results were exact. Still, this is a lot easier than anything I'd imagined.
Thanks for the great work!
I wrote a monstrous amount of python code to achieve this same effect, but my results were exact. Still, this is a lot easier than anything I'd imagined.
Thanks for the great work!
FreeCAD Trails workbench for transportation engineering: https://www.github.com/joelgraff/freecad.trails
pivy_trackers 2D coin3D library: https://www.github.com/joelgraff/pivy_trackers
pivy_trackers 2D coin3D library: https://www.github.com/joelgraff/pivy_trackers
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
Yes, you nailed it - thanks abdullah!
To me it looks like the size of the Fillet is determined by where the user clicks on the two existing arcs (maybe you alluded to that in your next post) - is that right?
In the event that multiple possible intersections exist, I think the user would expect the Fillet to be created near to where the cursor picks happened on the parent curves.
I wonder, do the directions in which the Arc and Arc Of Ellipse were originally created (clockwise or anti-clockwise) come into play there?
Thanks again abdullah; it's good to see you back coding again!
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
Thats how it works with straight lines.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines
Yes, but I'm asking about the curves...