0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby abdullah » Sun Oct 28, 2018 6:46 pm

Werner has merged it.
chrisb
Posts: 18898
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby chrisb » Mon Oct 29, 2018 12:30 am

Wait for the next build to test.
chrisb
Posts: 18898
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby chrisb » Mon Oct 29, 2018 12:41 am

Will test when it is available in daily.
User avatar
bejant
Posts: 5934
Joined: Thu Jul 11, 2013 3:06 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby bejant » Mon Oct 29, 2018 1:54 pm

abdullah wrote:
Sun Oct 28, 2018 6:46 pm
Werner has merged it.
Abdullah and Werner : thanks!
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby abdullah » Mon Oct 29, 2018 5:33 pm

bejant wrote:
Mon Oct 29, 2018 1:54 pm
abdullah wrote:
Sun Oct 28, 2018 6:46 pm
Werner has merged it.
Abdullah and Werner : thanks!
Welcome! It was in the bug tracker for a while.

BTW, it did not get into the PPA by some hours...

There is another PR for the trimming issues:
https://github.com/FreeCAD/FreeCAD/pull/1759

When that gets merged, I would appreciate some attention to Fillets and Trimming testing.
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby NormandC » Tue Oct 30, 2018 3:07 am

Thanks Abdullah and Werner!

I've briefly tested it in the latest daily that was rolled out on the PPA a few hours ago. I'm surprised it worked between a B-spline and a line! Cool! :)

There is one condition where it fails, and that is between a line and an arc perpendicular to it.

The line and arc were made with the polyline tool.

phpBB [video]


phpBB [video]


OS: Ubuntu 18.04.1 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15099 (Git)
Build type: Release
Branch: master
Hash: 1538a14eca0879be3d223930f7e5f78d4a24691c
Python version: 2.7.15rc1
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/Canada (fr_CA)
chrisb
Posts: 18898
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby chrisb » Tue Oct 30, 2018 11:47 pm

Observations:
- test of pathological tangent circlesarcs -> Error message in report view
- test of pathological tangent circlearc/line -> Error message in report view

- Arc and line towards the inside works if arc is selected first, although the points selected are not the endpoints of the fillet
- Arc and line towards the inside does not work, if line is selected first.
- Arc and line toward the outside works as expected.

Edits in blue.
chrisb
Posts: 18898
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby chrisb » Tue Oct 30, 2018 11:53 pm

If an arc and a line are not connected, then filleting works only if the line points outward and not inward of the circle.
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby NormandC » Wed Oct 31, 2018 1:43 am

chrisb wrote:
Tue Oct 30, 2018 11:47 pm
- test of pathological tangent circles
What are "pathological" tangent circles?
chrisb
Posts: 18898
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby chrisb » Wed Oct 31, 2018 5:56 am

NormandC wrote:
Wed Oct 31, 2018 1:43 am
What are "pathological" tangent circles?
Perhaps it was the wrong word. We use "pathological" to describe a situation with no practical usage beyond showing some fault, perhaps "silly" would have been better. In addition I said "circle" where it should read "arc". I have to confess, this time it cannot be excused with just a few typos.

I meant something like this ...
Bildschirmfoto 2018-10-31 um 06.53.12.png
Bildschirmfoto 2018-10-31 um 06.53.12.png (10.61 KiB) Viewed 231 times
...where it is not really sensible to add fillets. Well, at the left an arc could be inserted with a radius between those of the adjacent arcs, but at the right a "fillet" would have to be a straight line? So I just called these "pathological".