Wrong constraints after Carbon Copy from another body

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
kisolre
Posts: 2253
Joined: Wed Nov 21, 2018 1:13 pm

Wrong constraints after Carbon Copy from another body

Postby kisolre » Fri Apr 05, 2019 1:45 pm

In the supplied file when Carbon Copying sketch from another body in construction mode some constraints are marked as redundant. Carbon copying the same sketch in normal mode shows everything as ok. After copying in construction mode and manualy removing that constraints sketch shows as fully constrained but actually is not.
To reproduce:
Open the file.
Create new body.
Create new sketch.
Toggle construction mode On.
Make sure Auto Remove Redundants is Off
Carbon Copy "GalaxyS5Body.PulseSensor.Sketch005" - constraints 21,24 are showed as redundant.
Undo
Toggle construction mode Off.
Carbon Copy "GalaxyS5Body.PulseSensor.Sketch005" - no redundant constraints.
CarbonCopyConstruction.JPG
CarbonCopyConstruction.JPG (133.09 KiB) Viewed 208 times

Code: Select all

OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16267 (Git)
Build type: Release
Branch: master
Hash: ddb335cfe057336f1958d68126bb0471328d735c
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Bulgarian/Bulgaria (bg_BG)
Other versions tested:

Code: Select all

OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15816 (Git)
Build type: Release
Branch: master
Hash: 7ee0e4d43909ec688299b8498b240cccf8362c47
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Bulgarian/Bulgaria (bg_BG)
Shows 2 redundants

Code: Select all

OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.13541 (Git)
Build type: Release
Branch: releases/FreeCAD-0-17
Hash: 9948ee4f1570df9216862a79705afb367b2c6ffb
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: Bulgarian/Bulgaria (bg_BG)
shows only one redundant - 24
Attachments
S5BasicCover_Broken.FCStd
(671.08 KiB) Downloaded 54 times
chrisb
Posts: 25190
Joined: Tue Mar 17, 2015 9:14 am

Re: Wrong constraints after Carbon Copy from another body

Postby chrisb » Fri Apr 05, 2019 2:17 pm

We have seen all kinds of weird things happen, if you continue to work on a Sketch while the solver shows issues. It takes some of the freedoms a user has - e.g. to add another useful constraint before removing a redundancy - but it might be sensible to forbid any further action which adds new stuff to such a sketch or using it.
kisolre
Posts: 2253
Joined: Wed Nov 21, 2018 1:13 pm

Re: Wrong constraints after Carbon Copy from another body

Postby kisolre » Fri Apr 05, 2019 2:35 pm

chrisb wrote:
Fri Apr 05, 2019 2:17 pm
We have seen all kinds of weird things happen, if you continue to work on a Sketch while the solver shows issues. It takes some of the freedoms a user has - e.g. to add another useful constraint before removing a redundancy - but it might be sensible to forbid any further action which adds new stuff to such a sketch or using it.
This happens with blank sketch - so no possible issues. And there is a difference between a normal copy and construction copy - both with emptry sketch as a start.
chrisb
Posts: 25190
Joined: Tue Mar 17, 2015 9:14 am

Re: Wrong constraints after Carbon Copy from another body

Postby chrisb » Fri Apr 05, 2019 4:09 pm

I currently have a very bad internet connection, but finally I could download the file.

I can confirm the behaviour. I have tried to reproduce the situation with another sketch containing only a construction line and a regular one. That did not show the issue. So I upload here for ease of test a simplified file, which contains only the suspicious sketch showing the problem. It might be worth a tracker entry.
Attachments
CarbonCopyConstructionMode.FCStd
(3.8 KiB) Downloaded 53 times
kisolre
Posts: 2253
Joined: Wed Nov 21, 2018 1:13 pm

Re: Wrong constraints after Carbon Copy from another body

Postby kisolre » Fri Apr 05, 2019 4:58 pm

abdullah
Posts: 3502
Joined: Sun May 04, 2014 3:16 pm

Re: Wrong constraints after Carbon Copy from another body

Postby abdullah » Sat Jun 22, 2019 9:21 pm

kisolre wrote:
Fri Apr 05, 2019 1:45 pm
In the supplied file when Carbon Copying sketch from another body in construction mode some constraints are marked as redundant. Carbon copying the same sketch in normal mode shows everything as ok.
Thanks! This kind of analysis is priceless.

Once I read it works in normal mode and does not in construction mode, the problem being redundants being shown, I immediately knew which line to change. You made a very cumbersome debugging taking hours into a 5 minutes fix :D :D :D
kisolre
Posts: 2253
Joined: Wed Nov 21, 2018 1:13 pm

Re: Wrong constraints after Carbon Copy from another body

Postby kisolre » Sat Jun 22, 2019 9:30 pm

I try :-)