image scaling

[kisolre]

Works here too. While we are talking about image scale why are the default sizes rounded to whole mm? Shouldn't it be better for them to keep proper proportional image size or as I did when needed imported images - link their sizes through expression: YSize = XSize*ImageHeight/ImageWidth?

[easyw-fc]

But of course locale should be respected.

what for?
1) Units are not allowed in the input field...
2) ',' '.' are both accepted and converted to internal float

[UR_]

what for?

1,000 in german locale this means 1, with US locale activated it's the same as 1000.

[easyw-fc]

1,000 in german locale this means 1, with US locale activated it's the same as 1000.

but do you write 1000 or 1,000? or is i.e. the calculator app that is adding the separator?
EDIT:
'US locale' is not accepting the following number:

Code: Select all

1,000.5

it accepts only

Code: Select all

1000.5

[easyw-fc]

1,000 in german locale this means 1, with US locale activated it's the same as 1000

here a code supporting locale

_CommandImageScaling.py

(9.38 KiB) Downloaded 39 times

but still you cannot digit 1,000.5 but you have to digit 1000.5 in US locale and you must add the right separator (previous solution were accepting both)

While we are talking about image scale why are the default sizes rounded to whole mm? Shouldn't it be better for them to keep proper proportional image size or as I did when needed imported images - link their sizes through expression: YSize = XSize*ImageHeight/ImageWidth?

I don't see your point...
It should be just fine:

Code: Select all

s=d/self.distance
sel[0].XSize.Value=sel[0].XSize.Value*s
sel[0].YSize.Value=sel[0].YSize.Value*s

[kisolre]

I don't see your point...

Imported image proportion 207/161= 1,2857142857142857142857142857143
Actual image proportion 980/760 = 1,2894736842105263157894736842105
Imported image size is rounded to whole numbers.

ImagePlaneSize.JPG (230.7 KiB) Viewed 1391 times

[kisolre]

here a code supporting locale

Does not work here (BG). Decimal separator is ',' but neither ',' nor '.' work. I even tried copiing the symbol rom the control panel locale settings window without success.

[easyw-fc]

Imported image proportion 207/161= 1,2857142857142857142857142857143
Actual image proportion 980/760 = 1,2894736842105263157894736842105
Imported image size is rounded to whole numbers.
ImagePlaneSize.JPG

Now I see... this is related to cpp code, not python scale function...
https://github.com/FreeCAD/FreeCAD/blob ... x.cpp#L202
Would you post an issue @Mantis?

[easyw-fc]

here a code supporting locale

Does not work here (BG). Decimal separator is ',' but neither ',' nor '.' work. I even tried copiing the symbol rom the control panel locale settings window without success.

have you restarted FC to test it?
Could you then test the previous patch? (at the following link)
https://forum.freecadweb.org/posting.ph ... 1#pr305570

[kisolre]

That link throws me in Posting mode. If you mean the one that should accept either , or . I already posted that it works here.