[Solved] Ticket #3979 - pocket "up to face" only one hole

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
User avatar
GlouGlou
Posts: 2253
Joined: Sun Apr 05, 2015 9:02 am
Location: La Rochelle, France

[Solved] Ticket #3979 - pocket "up to face" only one hole

Postby GlouGlou » Fri May 17, 2019 5:25 pm

Trying to make two holes in this part. Up to face mode make only one. Why this behaviour?

OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16653 (Git)
Build type: Release
Branch: master
Hash: aaae82970461c10b76281f4e4454ab086b5f7f21
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: French/France (fr_FR)
Attachments
onehole.FCStd
(15.75 KiB) Downloaded 11 times
Capture.JPG
Capture.JPG (28.03 KiB) Viewed 415 times
Last edited by Kunda1 on Sat Jun 15, 2019 9:44 pm, edited 1 time in total.
openBrain
Posts: 4214
Joined: Fri Nov 09, 2018 5:38 pm

Re: pocket "up to face" only one hole

Postby openBrain » Fri May 17, 2019 6:10 pm

Confirmed here. Guess it's a bug. "Through all" works correctly. ;)
---
OS: Ubuntu 18.04.2 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.1.
Build type: Release
Python version: 2.7.15rc1
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)
User avatar
quick61
Posts: 3803
Joined: Sat Aug 24, 2013 2:49 am
Location: u.S.A.

Re: pocket "up to face" only one hole

Postby quick61 » Fri May 17, 2019 6:22 pm

Confirmed here as well. Up to face and To first fail, Dimension, (both single and 2 way), and Through all work as expected.

Mark

** Release date 2019/05/15 22:06:43 **

OS: Kubuntu 18.04.2 LTS (KDE/plasma)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.6.7
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
This post made with 0.0% Micro$oft products - GOT LINUX?
User avatar
meme2704
Posts: 2926
Joined: Sat Apr 01, 2017 2:47 pm
Location: Vosges

Re: pocket "up to face" only one hole

Postby meme2704 » Fri May 17, 2019 7:02 pm

Helas , I confirm too
V.19-pre on windows7
User avatar
GlouGlou
Posts: 2253
Joined: Sun Apr 05, 2015 9:02 am
Location: La Rochelle, France

Re: pocket "up to face" only one hole

Postby GlouGlou » Fri May 17, 2019 7:13 pm

bug ticket send. thanks
openBrain
Posts: 4214
Joined: Fri Nov 09, 2018 5:38 pm

Re: pocket "up to face" only one hole

Postby openBrain » Fri May 17, 2019 7:35 pm

GlouGlou wrote:
Fri May 17, 2019 7:13 pm
bug ticket send. thanks
issue #3979 ;)
wmayer
Site Admin
Posts: 15971
Joined: Thu Feb 19, 2009 10:32 am

Re: pocket "up to face" only one hole

Postby wmayer » Sat Jun 15, 2019 5:46 pm

Some references:
https://www.opencascade.com/doc/occt-7. ... algos.html

It looks like it's either a limitation or a bug in BRepFeat_MakePrism where of the passed profile shape (that's the filled sketch) only one face is used and the second one is ignored.

Btw, the class BRepFeat_MakePrism is also used for the UpToFace option of a pad. So, when you delete the pocket, create a pad, select UpToFace option then it also only creates one cylinder instead of two.
User avatar
Kunda1
Posts: 7532
Joined: Thu Jan 05, 2017 9:03 pm

Re: Ticket #3979 - pocket "up to face" only one hole

Postby Kunda1 » Sat Jun 15, 2019 9:45 pm

Updated thread title with relevant ticket #
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
papyblaise
Posts: 1985
Joined: Thu Jun 13, 2019 4:28 pm
Location: France

Re: Ticket #3979 - pocket "up to face" only one hole

Postby papyblaise » Sun Jun 16, 2019 4:38 pm

Any problem with V.19_pre
It works well
Attachments
multisketch.PNG
multisketch.PNG (12.41 KiB) Viewed 257 times
TheMarkster
Posts: 1574
Joined: Thu Apr 05, 2018 1:53 am

Re: Ticket #3979 - pocket "up to face" only one hole

Postby TheMarkster » Sun Jun 16, 2019 9:02 pm

I found these comments when browsing through the part design source code:

// A support object is always required and we need to use BRepFeat_MakePrism
// Problem: For Pocket/UpToFirst (or an equivalent Pocket/UpToFace) the resulting shape is invalid
// because the feature does not add any material. This only happens with the "2" option, though
// Note: It might be possible to pass a shell or a compound containing multiple faces
// as the Until parameter of Perform()
// Note: Multiple independent wires are not supported, we should check for that and
// warn the user

// FIXME: If the support shape is not the previous solid in the tree, then there will be unexpected results
// Check supportface for limits, otherwise Perform() throws an exception

Edit: The above was in the FeaturePad.cpp file, so perhaps is not relevant to pocket features?
My FreeCAD video series on youtube: https://www.youtube.com/c/mwganson