[Solved] Ticket #4136 - Hard crash using Addon Manager when multiple clicking on different addons

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
User avatar
yorik
Site Admin
Posts: 11547
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Ticket #4136 - Hard crash using Addon Manager when multiple clicking on different addons

Postby yorik » Thu Oct 10, 2019 5:34 pm

TThere is actually no need to uninstall anything... Just clicking through a few addons as fast as possible (just after they become clickable again) causes the crash

Weird...
User avatar
yorik
Site Admin
Posts: 11547
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Ticket #4136 - Hard crash using Addon Manager when multiple clicking on different addons

Postby yorik » Thu Oct 10, 2019 5:57 pm

Ok I think I nailed it git commit 77550e0de3

The problem was that a thread is launched to retrieve an addon description, and inside that thread, a separate method is launched to download the images. However, when calling thread.quit(), the thread is not able to finish before all running methods have returned. And so the thread was destroyed without having properly finished.
User avatar
uwestoehr
Posts: 745
Joined: Sun Jan 27, 2019 3:21 am

Re: Ticket #4136 - Hard crash using Addon Manager when multiple clicking on different addons

Postby uwestoehr » Thu Oct 10, 2019 8:03 pm

Kunda1 wrote:
Wed Oct 09, 2019 4:38 pm
Just a reminder, in case this got lost in all the noise
Yorik fixed it now: git commit 77550e0de38bec23af3b20be85eea38f9eb4fee7
I can confirm that the crash is now fixed. Many thanks!
User avatar
Kunda1
Posts: 5759
Joined: Thu Jan 05, 2017 9:03 pm

Re: [Solved] Ticket #4136 - Hard crash using Addon Manager when multiple clicking on different addons

Postby Kunda1 » Thu Oct 10, 2019 10:18 pm

Closed ticket and marked thread as [Solved]
Thanks!
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features