[bug] Crash after going in and out of fullscreen in sketch view

[qurn]

FreeCAD has a reproducible segfault after following these steps:

1. Open FreeCAD
2. Press the "create new document" button
3. Switch to the Sketcher workbench
4. Press the "Create a new sketch" button
5. Press OK (Selecting XY-Plane orientation)
6. Press F11 to go to full-screen of the document view
Note: Here we don't see the sketch we wanted to see on the full-screen
7. Press F11 to leave full-screen
8. Press "Close"
9. FreeCAD crashes

Info:
OS: Arch Linux
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.17646 (Git)
Build type: Unknown
Branch: master
Hash: 641d946fa47573562026e042b1706759bd47611e
Python version: 3.7.4
Qt version: 5.13.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)

[kisolre]

Confirmed with

OS: Windows 8.1 (6.3)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18293 (Git)
Build type: Release
Branch: master
Hash: 644fb4739df4d5ff25fbae8aa4db50331c60fe63
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Bulgarian/Bulgaria (bg_BG)

Full screen/undocked 3d view might not be same as docked one. And probably sketcher treats it in some way but other is expected? There was similar problem with general model view in fullscreen https://forum.freecadweb.org/viewtopic.php?f=3&t=36744

[wmayer]

This fixes the crash git commit 19ac3ecfc but the sketch still disappears when going to fullscreen mode. What you can do as workaround (once you have the fixed version):
1. Set fullscreen mode
2. Switch to main window and close the sketcher, start the editor again
3. Switch back to the fullscreen window

Now you should be able to work on the sketcher.

[wmayer]

Some more fixes:
This fixes a crash git commit 2a3d398a9b when switching to fullscreen, back to normal and then closing the document while the sketch is still in edit mode.
When you switch to fullscreen and back then the sketcher is broken when you leave edit mode because most of its Inventor nodes were removed from its view provider. This is fixed with git commit 28a915d821f
With this fix git commit 3ccba4c64 it's possible now to switch to fullscreen mode and directly edit the sketcher there.

[kisolre]

Thanks for the quick fix I hope I will not forget to test with the next build.

[qurn]

Thanks from me too. I have tested it and everything works like a charm now.