object has no attribute 'DiffuseColor' in recomputing BIM project

[danreb]

I've got an error on recomputing a project

Traceback (most recent call last):
File "/Users/***/miniconda/envs/freecad_py37/Mod/Arch/ArchBuildingPart.py", line 629, in updateData
colors = self.getColors(obj)
File "/Users/***/miniconda/envs/freecad_py37/Mod/Arch/ArchBuildingPart.py", line 649, in getColors
if len(child.ViewObject.DiffuseColor) == len(child.Shape.Faces):
<class 'AttributeError'>: 'Gui.ViewProviderDocumentObject' object has no attribute 'DiffuseColor'

This is due to WPProxy (the one automaticaly created whit the BIM porject setup tool), labels and text as can be seen from print traces I've put in the code

Code: Select all

BBL .... trace test no DiffuseColor === WPProxy
BBL .... trace test no DiffuseColor === WPProxy001
BBL .... trace test no DiffuseColor === WPProxy002
BBL .... trace test no DiffuseColor === WPProxy003
BBL .... trace test no DiffuseColor === Text
BBL .... trace test no DiffuseColor === Axis
BBL .... trace test no DiffuseColor === WPProxy004
BBL .... trace test no DiffuseColor === WPProxy
BBL .... trace test no DiffuseColor === WPProxy001
BBL .... trace test no DiffuseColor === WPProxy002
BBL .... trace test no DiffuseColor === WPProxy003
BBL .... trace test no DiffuseColor === dLabel002
BBL .... trace test no DiffuseColor === dLabel003
BBL .... trace test no DiffuseColor === dLabel
BBL .... trace test no DiffuseColor === dLabel001

I've modified the code [Mod/Arch/ArchBuildingPart.py] as follow to circumvent this blocking error

BEFORE .....

Code: Select all

    def getColors(self,obj):

        "recursively get the colors of objects inside this BuildingPart"

        colors = []
        for child in Draft.getGroupContents(obj):
            if hasattr(child,'Shape') :
                if len(child.ViewObject.DiffuseColor) == len(child.Shape.Faces):
                    colors.extend(child.ViewObject.DiffuseColor)
                else:
                    c = child.ViewObject.ShapeColor[:3]+(child.ViewObject.Transparency/100.0,)
                    for i in range(len(child.Shape.Faces)):
                        colors.append(c)
        return colors

AFTER ....

Code: Select all

    def getColors(self,obj):

        "recursively get the colors of objects inside this BuildingPart"

        colors = []
        for child in Draft.getGroupContents(obj):
            if hasattr(child,'Shape') and (hasattr(child.ViewObject,"DiffuseColor") or hasattr(child.ViewObject,"DiffuseColor")):
                if hasattr(child.ViewObject,"DiffuseColor") and len(child.ViewObject.DiffuseColor) == len(child.Shape.Faces):
                    colors.extend(child.ViewObject.DiffuseColor)
                else:
                    c = child.ViewObject.ShapeColor[:3]+(child.ViewObject.Transparency/100.0,)
                    for i in range(len(child.Shape.Faces)):
                        colors.append(c)
        return colors

OS: macOS Mojave (10.14)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.19107 (Git)
Build type: Release
Branch: master
Hash: ad952191297fe53593c4d4b0ac80b43fd6664b22
Python version: 3.7.6
Qt version: 5.12.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)

[danreb]

Hi Yorik what do you think of it? Should the Arch code be corrected?

[Kunda1]

Hi Yorik what do you think of it? Should the Arch code be corrected?

@danreb u need to add yorik's user_id=68 within the quote bbcode. You can learn a user's user_id by searching their username clicking on their profile and seeing the: u= part of the URL to get the number.

[vocx]

Code: Select all

...
            if hasattr(child,'Shape') and (hasattr(child.ViewObject,"DiffuseColor") or hasattr(child.ViewObject,"DiffuseColor")):
                if hasattr(child.ViewObject,"DiffuseColor") and len(child.ViewObject.DiffuseColor) == len(child.Shape.Faces):

I don't understand why you check for DiffuseColor twice.

In the second "if" you don't need to test for DiffuseColor again because we found it in the first "if" already.

But other than that the code looks fine.

Code: Select all

...
            if hasattr(child,'Shape') and hasattr(child.ViewObject,"DiffuseColor"):
                if len(child.ViewObject.DiffuseColor) == len(child.Shape.Faces):

[danreb]

...
I don't understand why you check for DiffuseColor twice.
...

Hi @vocx sorry for this duplicate entry. You are totaly right, actually the first check is for the attribute "DiffuseColor" and the second should have been for the attribute "ShapeColor" which is requested in the else par of the condition check and I got a null error on this property with one of my test.

the real code should be:

Code: Select all

    def getColors(self,obj):

        "recursively get the colors of objects inside this BuildingPart"

        colors = []
        for child in Draft.getGroupContents(obj):
            if hasattr(child,'Shape') and (hasattr(child.ViewObject,"DiffuseColor") or hasattr(child.ViewObject,"ShapeColor")):
                if hasattr(child.ViewObject,"DiffuseColor") and len(child.ViewObject.DiffuseColor) == len(child.Shape.Faces):
                    colors.extend(child.ViewObject.DiffuseColor)
                else:
                    c = child.ViewObject.ShapeColor[:3]+(child.ViewObject.Transparency/100.0,)
                    for i in range(len(child.Shape.Faces)):
                        colors.append(c)
        return colors

[danreb]

@danreb u need to add yorik's user_id

Hi thanks @Kunda1

ping !

[Kunda1]

PR submitted by OP: https://github.com/FreeCAD/FreeCAD/pull/3138