[?BUG] Addon Manager hangs in 0.19 on MacOS and possibly related issues.

[chrisb]

I finally found the culprit: If I change line 43 in addonmanager_utilities.py from

Code: Select all

        ssl_ctx = ssl.create_default_context(ssl.Purpose.SERVER_AUTH)

to

Code: Select all

        ssl_ctx = ssl.create_default_context(ssl.Purpose.CLIENT_AUTH)

AddonManager shows the list of workbenches again.

I don't understand the implications, so I don't know what to do. Should I create a pull request?

[looo]

I finally found the culprit

nice! I tested with windows and linux and the addon-manager works for both with the mentioned change. So please go ahead and create a PR.

Maybe apply the change only for py3.8.

Code: Select all

if sys.version_info.major >= 3 and sys.version_info.minor >= 8:
    ssl_ctx = ssl.create_default_context(ssl.Purpose.SERVER_AUTH)
else:
    ssl_ctx = ssl.create_default_context(ssl.Purpose.CLIENT_AUTH)

[easyw-fc]

@chrisb is asking if this would change something about how the SSL is handled... it seems client certificates don't encipt data...

No encryption of data takes place in case of Client certificates.

[looo]

@chrisb is asking if this would change something about how the SSL is handled... it seems client certificates don't encipt data...

No encryption of data takes place in case of Client certificates.

And this s a problem?

[easyw-fc]

And this s a problem?

in terms of privacy yes...
moreover we should discover why the server side option is working on Win and Linux but not on OSX...

[chrisb]

Can I do something to narrow this down?

[looo]

Can I do something to narrow this down?
[/quote

Maybe trying to reproduce the error directly with a conda-environment (not the bundle).

[easyw-fc]

this is reminding me an issue I had with AppImage which is now solved ... this is not instead solved on OSX bundle

We failed to reach a server.
Reason: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1108)

EDIT:
https://forum.freecadweb.org/viewtopic. ... 20#p327416

[chrisb]

Maybe apply the change only for py3.8.

It seems to be rather a MacOS issue than a Python 3.8 one. It seems that Apple has stopped supporting openSSL. It needs to be compiled which needs to install at least some xcode packages ...
I would prefer to make the distinction which authentication to use depend on the OS.

I could use one of these:
platform.system() which is on my system 'Darwin'
sys.platform which is on my system 'darwin'
platform.platform() which is on my system 'macOS-10.13.2-x86_64-i386-64bit'; I would use the first 5 characters for comparison.

Which one is the right way to go? Or should I use something else?

[triplus]

That is i guess one of the cons of using the latest versions of software, as you get to fix the new bugs.