Regression: Wrong helix icon in tree

[chrisb]

With the version below the helix icon in the tree is wrong, rather showing a curve or polyline:

Bildschirmfoto 2020-10-22 um 11.21.34.png (6.45 KiB) Viewed 270 times

It is still ok in the corresponding dialog:

Bildschirmfoto 2020-10-22 um 11.25.00.png (8.48 KiB) Viewed 270 times

OS: macOS 10.15
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.22756 (Git)
Build type: Release
Branch: master
Hash: ce87f586ee36ffe8ebcdcd3947ced4ab389ae795
Python version: 3.8.6
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: C/Default (C)

[wmayer]

The same for the spiral. The commit probably is git commit e6dd1df7a3e80 but I cannot detect what should be wrong there.

[wmayer]

The regression is caused by git commit 27e42f5b053e because ViewProviderSpline implements getIcon() with a hard-coded icon name and thus sub-classes like ViewProviderHelixParametric cannot simply overwrite the sPixmap class member.

[wmayer]

git commit 9d3625353

[chrisb]

Thanks for the very fast fix!