[fixed] [bug 4495] 45° rotation via NaviCube does not work

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [bug 4495] 45° rotation via NaviCube does not work

Post by uwestoehr »

UR_ wrote: Thu Feb 25, 2021 11:38 am ATM, most funny part of source NaviCube.cpp is text display of cs axes
:man_facepalming:
:lol: Yes, I have seen this too and fixing this as well is on my ToDo list.
User avatar
watsug
Posts: 100
Joined: Sat Sep 26, 2020 10:51 pm

Re: [bug 4495] 45° rotation via NaviCube does not work

Post by watsug »

uwestoehr wrote: Thu Feb 25, 2021 8:11 pm However, I have to keep the pull request simple. There is much room for improvements and since FC 0.19 is now ready we have plenty of time to make several PRs. My first PR will now only be to fix the missing 45° faces + that you can now change 2 parameters via the preferences dialog.
Very reasonable! :) Great work and big improvement!
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [bug 4495] 45° rotation via NaviCube does not work

Post by uwestoehr »

uwestoehr wrote: Thu Feb 25, 2021 8:13 pm
UR_ wrote: Thu Feb 25, 2021 11:38 am ATM, most funny part of source NaviCube.cpp is text display of cs axes
:man_facepalming:
:lol: Yes, I have seen this too and fixing this as well is on my ToDo list.
I removed them now in my PR because they don't provide additional info since we have the global coordinate system showing the axis labels as well. More important for the usability, in the cube's default size of 132 px the axis labels are "in the way" when you want to click onto a corner.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [bug 4495] 45° rotation via NaviCube does not work

Post by uwestoehr »

watsug wrote: Thu Feb 25, 2021 9:02 pm Great work and big improvement!
Thanks.
From my point of view the PR is now ready since I added now the corner rotation.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: [bug 4495] 45° rotation via NaviCube does not work

Post by Kunda1 »

Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply