It depends, but in general one should strive to split up commits into logical changes with the purpose of aiding review, and making it easier to revert if there are problems, so things that are wildly different or very large changes should not be grouped together. In other words, you don't necessarily have to.Gift wrote: ↑Tue Aug 03, 2021 9:17 amDo I have to split the commit in one for GUI and one for Part. Or is so a small fix in one commit possible? Thx for support.kkremitzki wrote:Aloha,
[ Ticket #4692 ] DefaultShapeVertexColor preference not used?
Forum rules
and Helpful information
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help
Also, be nice to others! Read the FreeCAD code of conduct!
Also, be nice to others! Read the FreeCAD code of conduct!
- kkremitzki
- Veteran
- Posts: 2518
- Joined: Thu Mar 03, 2016 9:52 pm
- Location: Illinois
Re: [ Ticket #4692 ] DefaultShapeVertexColor preference not used?
Is this a regression?
Re: [ Ticket #4692 ] DefaultShapeVertexColor preference not used?
In this context I don't understand regression.
Thank you for your statement.kkremitzki wrote: ↑Tue Aug 03, 2021 5:08 pm ...
It depends, but in general one should strive to split up commits into logical changes with the purpose of aiding review, and making it easier to revert if there are problems, so things that are wildly different or very large changes should not be grouped together. In other words, you don't necessarily have to.
- kkremitzki
- Veteran
- Posts: 2518
- Joined: Thu Mar 03, 2016 9:52 pm
- Location: Illinois
Re: [ Ticket #4692 ] DefaultShapeVertexColor preference not used?
Re: [ Ticket #4692 ] DefaultShapeVertexColor preference not used?
Someone has implement this option in the GUI. But this function only write the color in parameter list. But the value has never read by the ViewProvider. So, it has never worked.kkremitzki wrote: ↑Tue Aug 03, 2021 8:43 pmIn other words, is it something that used to work, but has been broken, or is it something that never worked at all?
Edit:
REGRESSIONS TESTS
FreeCAD Part example
Re: [ Ticket #4692 ] DefaultShapeVertexColor preference not used?
How close the ticket?kkremitzki wrote:Ding-dong ditch
Re: [ Ticket #4692 ] DefaultShapeVertexColor preference not used?
I closed it.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.