[ Ticket #4692 ] DefaultShapeVertexColor preference not used?

[kkremitzki]

Is this a regression?

Aloha,

Do I have to split the commit in one for GUI and one for Part. Or is so a small fix in one commit possible? Thx for support.

It depends, but in general one should strive to split up commits into logical changes with the purpose of aiding review, and making it easier to revert if there are problems, so things that are wildly different or very large changes should not be grouped together. In other words, you don't necessarily have to.

[Gift]

Is this a regression?
...

In this context I don't understand regression.

...
It depends, but in general one should strive to split up commits into logical changes with the purpose of aiding review, and making it easier to revert if there are problems, so things that are wildly different or very large changes should not be grouped together. In other words, you don't necessarily have to.

Thank you for your statement.

[kkremitzki]

Is this a regression?
...

In this context I don't understand regression.

In other words, is it something that used to work, but has been broken, or is it something that never worked at all?

[Gift]

Thanks for looking at this. I hope it gets approved and merged.

PR 4954

[Gift]

Is this a regression?
...

In this context I don't understand regression.

In other words, is it something that used to work, but has been broken, or is it something that never worked at all?

Someone has implement this option in the GUI. But this function only write the color in parameter list. But the value has never read by the ViewProvider. So, it has never worked.


Edit:

REGRESSIONS TESTS
FreeCAD Part example

[Gift]

Ding-dong ditch

How close the ticket?

[chrisb]

I closed it.